Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiplatformResourcesPackage not used in Android #317

Closed
lepicekmichal opened this issue Mar 11, 2022 · 2 comments · Fixed by #323
Closed

MultiplatformResourcesPackage not used in Android #317

lepicekmichal opened this issue Mar 11, 2022 · 2 comments · Fixed by #323
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lepicekmichal
Copy link

lepicekmichal commented Mar 11, 2022

Hello,
why is androidSetup inside MultiplatformResourcesPlugin still using manifest for getting package name?
I am passing multiplatformResourcesPackage variable and want to use that so there is no need to parse my AndroidManifest.

I am trying to use autoManifest plugin so I can generate my manifests but moko-resources is looking for it too soon, eagerly.

Please remove parsing AndroidManifest since I am passing the package name in setup variables. Or Add another option for ignoring it.

Thank you

@Alex009
Copy link
Member

Alex009 commented Mar 11, 2022

multiplatformResourcesPackage is not android package - it's destination where should be generated MR class.
android package from manifest required to locate R android class.
we can add setting androidResourcesPackage to manual setup in case when AndroidManifest can't be parsed

@lepicekmichal
Copy link
Author

lepicekmichal commented Mar 11, 2022

I see.
Okay, please add androidResourcesPackage then.

@Alex009 Alex009 self-assigned this Mar 23, 2022
@Alex009 Alex009 added the enhancement New feature or request label Mar 23, 2022
@Alex009 Alex009 added this to the 0.19.0 milestone Mar 23, 2022
Alex009 added a commit that referenced this issue Mar 25, 2022
Alex009 added a commit that referenced this issue Mar 25, 2022
@Alex009 Alex009 linked a pull request Mar 25, 2022 that will close this issue
Alex009 added a commit that referenced this issue Mar 25, 2022
Alex009 added a commit that referenced this issue Mar 25, 2022
Alex009 added a commit that referenced this issue Mar 25, 2022
@Alex009 Alex009 closed this as completed Mar 25, 2022
@Alex009 Alex009 mentioned this issue Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants