-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nord, Dracula, Solarized and Gruvbox themes #2170
Conversation
Dracula, not Drakula. |
@liigo , Except for Gruvbox, other themes are color palettes which are already utilised by many non code-syntax apps. And @hecrj wanted other color schemes than default light/dark, so i think it might be worthy to consider this. |
@varbhat Color palettes can be used to create UI themes, but palettes themself are not UI themes. I suggest you create your own new themes, and give them new names, but don't use the name of those palettes. And maybe, they will reside in third-party crates. (After that for a long while, some of them that's very popular maybe have good chances to be merged into core crate as built-in themes, or replace existing light/dark themes.) |
@hecrj , rustfmt'd. try again |
@hecrj I am adding catppuccin (https://github.com/catppuccin/catppuccin) themes and palettes too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🥳
@varbhat Open a new PR for that one! |
@hecrj , This PR is accordingly to how we discussed in Discord.
This PR does two things: