Fix tons of compiler warnings #44
Conversation
| @@ -0,0 +1,108 @@ | |||
| /* A Bison parser, made by GNU Bison 3.0.2. */ | |||
There was a problem hiding this comment.
oops, Engine/Base/Parser.hpp wasn't supposed to be committed, will push a fixed (and rebased) version in minute
91fa4f8 to
9f851e6
Compare
|
ok, removed accidentally committed files, should be fine now |
| @@ -509,7 +509,7 @@ CBrushPolygon &CBrushPolygon::CopyPolygon(CBrushPolygon &bp) | |||
| bpo_boxBoundingBox=bp.bpo_boxBoundingBox; | |||
| bpo_pbscSector=bp.bpo_pbscSector; | |||
| bpo_rsOtherSideSectors.Clear(); | |||
| bpo_lhShadingInfos; | |||
| //bpo_lhShadingInfos; // FIXME: DG: was this missing "= bp.bpo_lhShadingInfos" or something like that? | |||
There was a problem hiding this comment.
Since this is a copying function, bpo_lhShadingInfos = bp.bpo_lhShadingInfos; is very likely what was intended.
There was a problem hiding this comment.
well, /could/ be, but some other fields were cleared or set to NULL, so I don't know for sure.. and it seems to work like it is, so unless a bug appears due to that field not being copied, maybe it should just be left commented out?
There was a problem hiding this comment.
Actually you can not copy list heads. bpo_lhShadingInfos is a CListHead, isn't it?
| @@ -246,7 +246,7 @@ void LastUnreadMessage(void) | |||
| // go to next/previous message | |||
| void PrevMessage(void) | |||
| { | |||
| if (_iActiveMessage<_acmMessages.Count()==0) { | |||
| if (_iActiveMessage < _acmMessages.Count()==0) { // FIXME: DG: what is this about? | |||
There was a problem hiding this comment.
This seems to be equivalent to if ( ! (_iActiveMessage < _acmMessages.Count()) ) which seems to make sense.. - any objections?
There was a problem hiding this comment.
So written in a non-obfuscated way, that would be if (_iActiveMessage >= _acmMessages.Count()), right?
There was a problem hiding this comment.
I think so, yes.
My original confusion when adding the FIXME to the code came from assuming that it was supposed to mean if(_iActiveMessage < (_acmMessages.Count()==0)), but > has higher priority than == so that assumption was incorrect
There was a problem hiding this comment.
I replaced it with if (_iActiveMessage >= _acmMessages.Count()) now.
|
hmm now github claims there are merge conflicts - will rebase to master in a minute |
the builtins are only used when using GCC or clang, of course, otherwise the usual shifting is done. Them being inline functions instead of macros increases type safety and gets rid of problems with signed shifts. Changed two places in the code that swapped bytes in 32bit ints to use BYTESWAP32_unsigned() instead - in case of PrepareTexture() this has probably even fixed issues with signed shifts
Fixed -Wreorder warnings (hopefully the last?), also several potentially uninitialized variables. In SetupPixelFormat_OGL() Assert if gap_iDepthBits ends up being 0. Small adjustments to cmake warning settings for gcc/clang
many unused functions and variables are now commented out You'll still get tons of warnings, which should mostly fall in one of the following categories: 1. Unnecessary variables or values generated from .es scripts 2. Pointers assigned to from functions with side-effects: DO NOT REMOVE! Like CEntity *penNew = CreateEntity_t(...); - even if penNew isn't used, CreateEntity() must be called there!
except for EntitiesMP/Fish.es which I'm not sure about, and in Computer.cpp the weird "if (_iActiveMessage < _acmMessages.Count()==0)" construct whichs intention I didn't fully grasp, either.
Seems like on Windows 0 bits is handled as "Let Windows/Driver decide", so handle that case by setting a reasonable value of 16.
Thanks to @SLAwww's explanations it's clear now :)
.. still, didn't look at unused variable warnings from *.es because so many are generated.
and replace the corresponding conditions with more readable (but equivalent) ones.
|
now it's mergeable again. |
only for the TSE build, I guess when building TFE there are some moreboth for TSE and TFE builds
also includes a commit fixing the depth buffer problems from #37