Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue465 multizone office simple hydronic #654

Conversation

icupeiro
Copy link
Contributor

@icupeiro icupeiro commented Jul 8, 2024

@dhblum as requested

@icupeiro
Copy link
Contributor Author

icupeiro commented Jul 8, 2024

Please revise because it seems there were some old commits from January that were not merged in this branch.
Looking at the files changed, it seems OK to me. There are many format adaptations depending on whether I used OM (simulation) or Dymola (actual coding/modeling work)

@dhblum
Copy link
Collaborator

dhblum commented Jul 8, 2024

Thank you @icupeiro! Regarding the commits from January, there were certain commits that worked or not for different tools. In particular, I remember the input statement and connector being part of this. I made the supply temperatures update here: 829c2a1. I will double check things though and see which of the commits from this PR are needed or not.

@dhblum
Copy link
Collaborator

dhblum commented Jul 15, 2024

Ok I double checked that your first 6 commits are actually changes that are included in the ibpsa branch already. Furthermore, I cherry-picked c0a2e89 and 7f5200a to the ibpsa branch. Finally, I looked things over again, compiled and simulated with OCT 1.51.6, and verified the fixes look good. See #465 (comment).

These commits can be found in #619 now, and I will close this PR without merging.

@dhblum dhblum closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants