Issue465 multizone office simple hydronic #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 3, 2024 16:39
…ed conditional input connector
…ithub.com/ibpsa/project1-boptest into issue465_multizone_office_simple_hydronic
|
I don't think those extra commits (especially 5c47043) will work. I had to create the valid model using this PR #618, so I think its easier/safer to make the changes to icupeiro:issue465_multizone_office_simple_hydronic_oct and not to icupeiro:issue465_multizone_office_simple_hydronic. |
|
closed due to mix up branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhblum here the PR
Hopefully is alright since I see some extra commits apart from the ones I did yesterday...