Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gclient fails while installing sysroot on ppc/s390 #1

Closed
jbajwa opened this issue Jun 30, 2016 · 2 comments
Closed

gclient fails while installing sysroot on ppc/s390 #1

jbajwa opened this issue Jun 30, 2016 · 2 comments
Assignees
@jbajwa
Labels
5.3

Comments

@jbajwa
Copy link

jbajwa commented Jun 30, 2016 •
edited
Loading

gclient sync tries to download sysroot tarballs from googlestorage and perform an installation which are not present for ppc/s390 and therefore it fails.
..
..
Downloading 1 files took 0.005829 second(s)

________ running '/usr/bin/python v8/build/linux/sysroot_scripts/install-sysroot.py --running-as-hook' in '/home/jbajwa/ppcle_v8'
Unrecognized host arch: ppc64le
Error: Command '/usr/bin/python v8/build/linux/sysroot_scripts/install-sysroot.py --running-as-hook' returned non-zero exit status 1 in /home/jbajwa/ppcle_v8

Proposed fix:

diff --git a/detect_host_arch.py b/detect_host_arch.py
index ccfbb6e..8d6a1ba 100755
--- a/detect_host_arch.py
+++ b/detect_host_arch.py
@@ -23,6 +23,11 @@ def HostArch():
     host_arch = 'arm'
   elif host_arch.startswith('mips'):
     host_arch = 'mips'
+  elif host_arch.startswith('ppc'):
+    host_arch = 'ppc'
+  elif host_arch.startswith('s390'):
+    host_arch = 's390'
+

   # platform.machine is based on running kernel. It's possible to use 64-bit
   # kernel with 32-bit userland, e.g. to give linker slightly more memory.
diff --git a/linux/sysroot_scripts/install-sysroot.py b/linux/sysroot_scripts/install-sysroot.py
index 2003ff6..77b2e56 100755
--- a/linux/sysroot_scripts/install-sysroot.py
+++ b/linux/sysroot_scripts/install-sysroot.py
@@ -82,6 +82,10 @@ def DetectHostArch():
     return 'arm'
   elif detected_host_arch == 'mips':
     return 'mips'
+  elif detected_host_arch == 'ppc':
+    return 'ppc'
+  elif detected_host_arch == 's390':
+    return 's390'

   raise Error('Unrecognized host arch: %s' % detected_host_arch)

@@ -141,7 +145,8 @@ def main(args):
   parser.add_option('--arch', type='choice', choices=valid_archs,
                     help='Sysroot architecture: %s' % ', '.join(valid_archs))
   options, _ = parser.parse_args(args)
-  if options.running_as_hook and not sys.platform.startswith('linux'):
+  host_arch = DetectHostArch()
+  if (options.running_as_hook and not sys.platform.startswith('linux')) or host_arch in ('ppc','s390'):
     return 0

   if options.running_as_hook:
@joransiu joransiu added the 5.3 label Jul 1, 2016
joransiu pushed a commit that referenced this issue Jul 21, 2016
@mi-ac
Revert of [gn] Fix valgrind config (patchset #1 id:1 of https://coder…
8d65a3c 
…eview.chromium.org/2109403002/ )

Reason for revert:
Breaks...

Original issue's description:
> [gn] Fix valgrind config
>
> BUG=chromium:474921
> NOTRY=true
> NOTREECHECKS=true
> TBR=vogelheim@chromium.org, jochen@chromium.org
>
> Committed: https://crrev.com/e97c990a2b1fd0b5b90832a7f182daa25fee8291
> Cr-Commit-Position: refs/heads/master@{#37418}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2109423002
Cr-Commit-Position: refs/heads/master@{#37419}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@mi-ac
Revert of [gn] Switch linux64 debug and internal snapshot to gn (patc…
fbeb0e6 
…hset #1 id:1 of https://codereview.chromium.org/2105353002/ )

Reason for revert:
Breaks...

Original issue's description:
> [gn] Switch linux64 debug and internal snapshot to gn
>
> BUG=chromium:474921
>
> Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7
> Cr-Commit-Position: refs/heads/master@{#37414}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2109503007
Cr-Commit-Position: refs/heads/master@{#37420}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@jaro-sevcik
Revert of [compiler] Load elimination now traverses CheckTaggedPointe…
f496f80 
…r. (patchset #1 id:1 of https://codereview.chromium.org/2104893002/ )

Reason for revert:
Clusterfuzz breakage (https://bugs.chromium.org/p/chromium/issues/detail?id=624756)

Original issue's description:
> [compiler] Load elimination now traverses CheckTaggedPointer.
>
> It also dereferences the inputs of StoreField, if those were
> CheckTaggedPointers. Tested manually.
>
> BUG=
>
> Committed: https://crrev.com/f416886358c0aeaa5b4d1e83d9c7d6bb8b0e7f2f
> Cr-Commit-Position: refs/heads/master@{#37330}

TBR=bmeurer@chromium.org,bgeron@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2113623002
Cr-Commit-Position: refs/heads/master@{#37438}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@ajklein
Reland of Add crash instrumentation for crbug.com/621147 (patchset #1 …
6e98325 
…id:1 of https://codereview.chromium.org/2118493002/ )

Reason for revert:
By request from ishell, plan is to leave this in master for awhile longer

Original issue's description:
> Revert of Add crash instrumentation for crbug.com/621147 (patchset #5 id:80001 of https://codereview.chromium.org/2100313002/ )
>
> Reason for revert:
> Instrumentation not needed on master branch
>
> Original issue's description:
> > Add crash instrumentation for crbug.com/621147
> >
> > BUG=chromium:621147
> > LOG=N
> > R=ishell@chromium.org,cbruni@chromium.org
> >
> > Committed: https://crrev.com/5ff508a82299f20a0d9828cf73072a4f4772fab8
> > Cr-Commit-Position: refs/heads/master@{#37328}
>
> TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=chromium:621147, chromium:624764
>
> Committed: https://crrev.com/b324850900e531ccee03f1712333f13dfcf15427
> Cr-Commit-Position: refs/heads/master@{#37456}

TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:621147, chromium:624764

Review-Url: https://codereview.chromium.org/2114743002
Cr-Commit-Position: refs/heads/master@{#37458}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@jakobkummerow
Revert of Add crash instrumentation for crbug.com/621147 (patchset #1 …
a182588 
…id:1 of https://codereview.chromium.org/2114743002/ )

Reason for revert:
Bug found and fixed: crrev.com/7614362b7e619f9c6c1d2681c6de02b966782d0e

Instrumentation no longer needed.

Original issue's description:
> Add crash instrumentation for crbug.com/621147
>
> BUG=chromium:621147
> LOG=N
> R=ishell@chromium.org,cbruni@chromium.org
>
> Committed: https://crrev.com/5ff508a82299f20a0d9828cf73072a4f4772fab8
> Cr-Commit-Position: refs/heads/master@{#37328}

TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org,adamk@chromium.org
BUG=chromium:621147, chromium:624764

Review-Url: https://codereview.chromium.org/2127813002
Cr-Commit-Position: refs/heads/master@{#37552}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@mi-ac
Reland of [gn] Switch more linux32 bots to gn (patchset #1 id:1 of ht…
d3413fa 
…tps://codereview.chromium.org/2128493002/ )

Reason for revert:
Should be fixed after https://codereview.chromium.org/2123223002/

Original issue's description:
> Revert of [gn] Switch more linux32 bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2122933002/ )
>
> Reason for revert:
> Breaks test isolation on shared library bot.
>
> Original issue's description:
> > [gn] Switch more linux32 bots to gn
> >
> > This switches nosnap and shared library bots to gn.
> >
> > This also unsets external startup data if no snapshot is
> > used.
> >
> > BUG=chromium:474921
> > NOTRY=true
> >
> > Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a
> > Cr-Commit-Position: refs/heads/master@{#37546}
>
> TBR=vogelheim@chromium.org,jochen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:474921
>
> Committed: https://crrev.com/a5fa2984257a50ee9440914c7d1a199f64a86194
> Cr-Commit-Position: refs/heads/master@{#37548}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2126843002
Cr-Commit-Position: refs/heads/master@{#37558}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@littledan
Revert of [esnext] ship --harmony-object-values-entries (patchset #1 …
1177750 
…id:1 of https://codereview.chromium.org/2116053003/ )

Reason for revert:
Revert to see if it addresses the performance regression observed in chromium:625956 in automated graphs

Original issue's description:
> [esnext] ship --harmony-object-values-entries
>
> BUG=v8:4663
> R=littledan@chromium.org, adamk@chromium.org
>
> Committed: https://crrev.com/ab529234853a1768642f8f6c907aaaa5ea8b19bf
> Cr-Commit-Position: refs/heads/master@{#37485}

TBR=adamk@chromium.org,caitpotter88@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:4663

Review-Url: https://codereview.chromium.org/2129533004
Cr-Commit-Position: refs/heads/master@{#37566}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@littledan
Reland of [esnext] ship --harmony-object-values-entries (patchset #1 …
62c950b 
…id:1 of https://codereview.chromium.org/2129533004/ )

Reason for revert:
Performance stayed the same after the revert; relanding.

Original issue's description:
> Revert of [esnext] ship --harmony-object-values-entries (patchset #1 id:1 of https://codereview.chromium.org/2116053003/ )
>
> Reason for revert:
> Revert to see if it addresses the performance regression observed in chromium:625956 in automated graphs
>
> Original issue's description:
> > [esnext] ship --harmony-object-values-entries
> >
> > BUG=v8:4663
> > R=littledan@chromium.org, adamk@chromium.org
> >
> > Committed: https://crrev.com/ab529234853a1768642f8f6c907aaaa5ea8b19bf
> > Cr-Commit-Position: refs/heads/master@{#37485}
>
> TBR=adamk@chromium.org,caitpotter88@gmail.com
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=v8:4663
>
> Committed: https://crrev.com/1177750a98faaa11e92ece13b70115bf704baf3b
> Cr-Commit-Position: refs/heads/master@{#37566}

TBR=adamk@chromium.org,caitpotter88@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4663

Review-Url: https://codereview.chromium.org/2127253002
Cr-Commit-Position: refs/heads/master@{#37596}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@mi-ac
Reland of [gn] Switch gcc bots to gn (patchset #1 id:1 of https://cod…
168d9ea 
…ereview.chromium.org/2130303002/ )

Reason for revert:
Relanding as the goma problem is due to an upgrade of the binutils version we use.

Original issue's description:
> Revert of [gn] Switch gcc bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2124263002/ )
>
> Reason for revert:
> There are a bunch of goma errors on the gcc bot now. Maybe connected to this CL.
>
> https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19068
>
> Original issue's description:
> > [gn] Switch gcc bots to gn
> >
> > BUG=chromium:474921
> >
> > Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393
> > Cr-Commit-Position: refs/heads/master@{#37580}
>
> TBR=vogelheim@chromium.org,jochen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:474921
>
> Committed: https://crrev.com/980d0d6e227f8de3cc0b71a0d3f492908adcf138
> Cr-Commit-Position: refs/heads/master@{#37603}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2132333002
Cr-Commit-Position: refs/heads/master@{#37624}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@mi-ac
Revert of [gn] Experiment: Reset -O3 to -O2. (patchset #1 id:1 of htt…
ce52650 
…ps://codereview.chromium.org/2135313002/ )

Reason for revert:
Data collected

Original issue's description:
> [gn] Experiment: Reset -O3 to -O2.
>
> Temporary commit to see performance data. Will be reverted
> shortly after.
>
> BUG=chromium:622332
> TBR=vogelheim, jochen
> NOTRY=true
>
> Committed: https://crrev.com/bbb61d8aea732457e1d5a0c9abdd79eacf1622ae
> Cr-Commit-Position: refs/heads/master@{#37667}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:622332

Review-Url: https://codereview.chromium.org/2141113002
Cr-Commit-Position: refs/heads/master@{#37690}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@bakkot
Reland of Add errors for declarations which conflict with catch param…
819fe04 
…eters. (patchset #1 id:1 of https://codereview.chromium.org/2112223002/ )

Reason for revert:
Correcting issue.

Original issue's description:
> Revert of Add errors for declarations which conflict with catch parameters. (patchset #6 id:100001 of https://codereview.chromium.org/2109733003/ )
>
> Reason for revert:
> Fuzzer claims `try {  \"\" ; } catch(x) { let x1 = [1,,], x = x; }` causes a crash.
>
> Original issue's description:
> > Add errors for declarations which conflict with catch parameters.
> >
> > Catch parameters are largely treated as lexical declarations in the
> > block which contains their body for the purposes of early syntax errors,
> > with some exceptions outlined in B.3.5. This patch introduces most of
> > those errors, except those from `eval('for (var e of ...);')` inside of
> > a catch with a simple parameter named 'e'.
> >
> > Note that annex B.3.5 allows var declarations to conflict with simple
> > catch parameters, except when the variable declaration is the init of a
> > for-of statement.
> >
> > BUG=v8:5112,v8:4231
> >
> > Committed: https://crrev.com/2907c726b2bb5cf20b2bec639ca9e6a521585406
> > Cr-Commit-Position: refs/heads/master@{#37462}
>
> TBR=littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:5112,v8:4231
>
> Committed: https://crrev.com/8834d5ecb559001c87c42322969471da60574a8c
> Cr-Commit-Position: refs/heads/master@{#37464}

R=littledan@chromium.org
BUG=v8:5112,v8:4231

Review-Url: https://codereview.chromium.org/2119933002
Cr-Commit-Position: refs/heads/master@{#37728}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@camillobruni
Reland of Avoid Context::Enter and Context::Exit if we're reentering …
1b44afe 
…the active and last entered context (patchset #1 id:1 of https://codereview.chromium.org/2140563002/ )

Reason for reland:
https://codereview.chromium.org/2122953002 fixed context issues.

Original issue's description:
> Revert of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (patchset #2 id:20001 of https://codereview.chromium.org/2131483002/ )
>
> Reason for revert:
> crashes: crbug.com/626719
>
> Original issue's description:
> > Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context
> >
> > A bit of browsing around indicates that the new fast-path is taken most of the time:
> >    3496 Entering new
> >  152295 Reentering same
> >
> > BUG=
> >
> > Committed: https://crrev.com/1829eb661ef1cf432fb551bcb193f521a219d490
> > Cr-Commit-Position: refs/heads/master@{#37570}
>
> TBR=jochen@chromium.org,verwaest@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=
>
> Committed: https://crrev.com/bec49a4876fdf8a20600ecdfc8534d0ef45c9528
> Cr-Commit-Position: refs/heads/master@{#37632}

TBR=jochen@chromium.org,verwaest@chromium.org,jkummerow@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2152803003
Cr-Commit-Position: refs/heads/master@{#37778}
joransiu pushed a commit that referenced this issue Jul 21, 2016
@mi-ac
Revert of Fix double-building of v8 in GN builds when setting just v8…
f6f8062 
…_target_cpu. (patchset #1 id:1 of https://codereview.chromium.org/2166173002/ )

Reason for revert:
Breaks:
https://build.chromium.org/p/client.v8.fyi/builders/V8%20Android%20GN%20%28dbg%29/builds/4590

And also the trybot:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/99806

Original issue's description:
> Fix double-building of v8 in GN builds when setting just v8_target_cpu.
>
> Because of the somewhat strange way default toolchains and custom
> toolchains and user-specified arguments work in GN, if you did a v8
> build that just set v8_target_cpu, you could end up building two
> identical copies of v8 (see the comments in the change for more).
>
> This CL identifies that case and fixes it.
>
> R=machenbach@chromium.org
> BUG=629825
>
> Committed: https://crrev.com/3536db45c9409c9aadc4eee6004cf337c0588cdb
> Cr-Commit-Position: refs/heads/master@{#37926}

TBR=dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=629825

Review-Url: https://codereview.chromium.org/2167113002
Cr-Commit-Position: refs/heads/master@{#37936}
@jbajwa jbajwa mentioned this issue Aug 18, 2016
Open
@jbajwa
Copy link
Author

jbajwa commented Sep 29, 2016

https://codereview.chromium.org/2368943005/

@jbajwa jbajwa closed this as completed Sep 29, 2016
@jbajwa
Copy link
Author

jbajwa commented Sep 30, 2016

https://codereview.chromium.org/2382883003

jbajwa pushed a commit that referenced this issue Oct 24, 2016
@schuay
Revert of [ic] Support data handlers that represent simple field stor…
a4ff04a 
…es. (patchset #1 id:20001 of https://chromiumcodereview.appspot.com/2438553003/ )

Reason for revert:
http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/9299

Original issue's description:
> [ic] Support data handlers that represent simple field stores.
>
> BUG=

TBR=jkummerow@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2439053002
Cr-Commit-Position: refs/heads/master@{#40505}
jbajwa pushed a commit that referenced this issue Oct 26, 2016
Revert of [compiler] Prepare for partially shipping Ignition. (patchset
6dd0587 
#1 id:1 of https://codereview.chromium.org/2443573002/ )

Reason for revert:
Causes regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=658711

Original issue's description:
> [compiler] Prepare for partially shipping Ignition.
>
> This prepares the code-base so that Ignition can be enabled on a certain
> subset of compilations without setting the {FLAG_ignition} flag (which
> enables Ignition on all compilations). We should not check the flag in
> question explicitly anywhere outside of the compiler heuristics.
>
> R=mvstanton@chromium.org

BUG=chromium:658711
TBR=mvstanton@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2448443002
Cr-Commit-Position: refs/heads/master@{#40534}
jbajwa pushed a commit that referenced this issue Oct 26, 2016
@ulan
Revert of Reland "[heap] Start sweeper tasks after evacuation. (patch…
59fb095 
…set #2 id:20001 of https://chromiumcoder… (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2437873004/ )

Reason for revert:
Canary crashes crbug.com/658718

Original issue's description:
> Reland "[heap] Start sweeper tasks after evacuation. (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428043002/ )"
>
> The performance regression in crbug.com/657776 was not caused by this CL.
>
> This reverts commit 4490a76.
>
> BUG=

TBR=mlippautz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2446583003
Cr-Commit-Position: refs/heads/master@{#40539}
jbajwa pushed a commit that referenced this issue Oct 26, 2016
@mi-ac
Revert of [modules] Add partial support for debug-scopes. (patchset #1 …
de52faf 
…id:1 of https://codereview.chromium.org/2445683002/ )

Reason for revert:
Breaks https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/9349

Original issue's description:
> [modules] Add partial support for debug-scopes.
>
> Setting variables is not yet implemented..
>
> R=adamk@chromium.org
> BUG=v8:1569

TBR=adamk@chromium.org,yangguo@chromium.org,neis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:1569

Review-Url: https://codereview.chromium.org/2449883002
Cr-Commit-Position: refs/heads/master@{#40564}
mcornac pushed a commit that referenced this issue Nov 2, 2016
@jakobkummerow
Revert of [ic] Experiment: disable map-specific handler cache. (patch…
5ce9760 
…set #1 id:1 of https://codereview.chromium.org/2462973003/ )

Reason for revert:
Causes performance regressions (up to 10% on the "IC" bucket). :-(

Original issue's description:
> [ic] Experiment: disable map-specific handler cache.
>
> IC data handlers support most of the hot cases nowdays. Let's see if
> the map-specific code cache still help us to improve things.
>
> BUG=v8:5561

TBR=ishell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5561

Review-Url: https://codereview.chromium.org/2474653002
Cr-Commit-Position: refs/heads/master@{#40701}
jbajwa pushed a commit that referenced this issue Nov 9, 2016
@camillobruni
Revert of [tools] Support custom script injection for callstats.py (p…
fdf0b3e 
…atchset #1 id:1 of https://codereview.chromium.org/2455623002/ )

Reason for revert:
speculative revert to address regressions on cnn.com benchmark.

Original issue's description:
> [tools] Support custom script injection for callstats.py
>
> This is a poor-man's solution to trigger page interactions.
>
> BUG=

TBR=jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2464053005
Cr-Commit-Position: refs/heads/master@{#40710}
jbajwa pushed a commit that referenced this issue Nov 9, 2016
@ulan
Revert of [heap] Invoke incremental marking step before allocation. (…
8f85aba 
…patchset #1 id:1 of https://codereview.chromium.org/2464393002/ )

Reason for revert:
Performance regression on Octane and V8 runtime stats.

Original issue's description:
> [heap] Invoke incremental marking step before allocation.
>
> This ensures that the newly allocated object immediatly precedes the
> linear allocation area, which is needed for allocation folding.
>
> For more info see:
> https://bugs.chromium.org/p/chromium/issues/detail?id=659165#c13
>
> BUG=chromium:659165

TBR=hpayer@chromium.org,mlippautz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:659165

Review-Url: https://codereview.chromium.org/2472043002
Cr-Commit-Position: refs/heads/master@{#40713}
jbajwa pushed a commit that referenced this issue Nov 9, 2016
@ulan
Revert of [heap] Add a guard for restarting the memory reducer after …
3c96c5e 
…mark-compact. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2433933005/ )

Reason for revert:
Speculative revert to see impact on crbug.com/659531

Original issue's description:
> [heap] Add a guard for restarting the memory reducer after mark-compact.
>
> Currently it is possible to get into a cycle of
> mark-compact -> memory reducer -> mark-compact -> memory reducer ...
> where the memory reducer does not free memory.
>
> This patch ensures that the memory reducer restarts only if the
> committed memory increased by sufficient amount after the last run.
>
> BUG=

TBR=hpayer@chromium.org,davidroutier17@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2472053003
Cr-Commit-Position: refs/heads/master@{#40737}
jbajwa pushed a commit that referenced this issue Nov 22, 2016
@rmcilroy
Revert of [compiler] Enable shared function marking by default (patch…
7b1a048 
…set #1 id:1 of https://codereview.chromium.org/2491773006/ )

Reason for revert:
Revert because it depends on https://codereview.chromium.org/2478323002/ which has been reverted.

Original issue's description:
> [compiler] Enable shared function marking by default
>
> BUG=v8:5512

TBR=bmeurer@chromium.org,leszeks@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5512

Review-Url: https://codereview.chromium.org/2491643006
Cr-Commit-Position: refs/heads/master@{#40926}
jbajwa pushed a commit that referenced this issue Nov 22, 2016
@bmeurer
Revert of MIPS: Optimize load/store with large offset (patchset #1 id…
fae0e71 
…:1 of https://codereview.chromium.org/2486283003/ )

Reason for revert:
Breaks CQ trybots now, i.e. https://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/24703/steps/compile%20with%20ninja/logs/stdio

Original issue's description:
> MIPS: Optimize load/store with large offset
>
> Currently, we are using the following sequence for load/store with large offset (offset > 16b):
>
>     lui at, 0x1234
>     ori at, at, 0x5678
>     add at, s0, at
>     lw  a0, 0(at)
>
> This sequence can be optimized in the following way:
>
>     lui at, 0x1234
>     add at, s0, at
>     lw  a0, 0x5678(at)
>
> BUG=

TBR=ivica.bogosavljevic@imgtec.com,miran.karic@imgtec.com,v8-mips-ports@googlegroups.com,dusan.simicic@imgtec.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2500863003
Cr-Commit-Position: refs/heads/master@{#40959}
jbajwa pushed a commit that referenced this issue Nov 22, 2016
@jaro-sevcik
Revert of [turbofan] Fix deoptimization of boolean bit constants. (pa…
1c9528c 
…tchset #1 id:1 of https://codereview.chromium.org/2495243002/ )

Reason for revert:
Seems to break GC stress.

Original issue's description:
> [turbofan] Fix deoptimization of boolean bit constants.
>
> BUG=chromium:664490

TBR=bmeurer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:664490

Review-Url: https://codereview.chromium.org/2502613002
Cr-Commit-Position: refs/heads/master@{#40961}
mcornac pushed a commit that referenced this issue Apr 18, 2017
@ajklein
Version 5.1.281.66 (cherry-pick)
bf7aa5e 
Merged 43a10a0

Disable Array.prototype.values

BUG=chromium:615873,v8:4247
LOG=N
R=littledan@chromium.org

Review URL: https://codereview.chromium.org/2083663002 .

Cr-Commit-Position: refs/branch-heads/5.1@{v8#77}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
@verwaest
Version 5.1.281.67 (cherry-pick)
a9ddcde 
Fix 'typeof null' canonicalization in crankshaft

R=cbruni@chromium.org
BUG=chromium:604033

Review URL: https://codereview.chromium.org/2088783002 .

Cr-Commit-Position: refs/branch-heads/5.1@{v8#78}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
Version 5.1.281.68 (cherry-pick)
b96114f 
Merged 36807f0

[crankshaft] Fix DoDeferredMathAbsTaggedHeapNumber overwriting the context with some temporary value.

BUG=v8:5067
LOG=N
R=bmeurer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2086243002
Cr-Commit-Position: refs/branch-heads/5.1@{v8#79}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
@isheludko
Version 5.1.281.68 (cherry-pick)
4bee188 
Merged 9fa206e
Merged 3e0be8d

[runtime] Ensure that all elements kind transitions are chained to the root map.

[runtime] Don't use ElementsTransitionAndStoreStub for transitions that involve instance rewriting.

BUG=chromium:617524,v8:5009,v8:5009
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/2086483005 .

Cr-Commit-Position: refs/branch-heads/5.1@{v8#80}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
Version 5.1.281.69
dc81244 
Cr-Commit-Position: refs/branch-heads/5.1@{v8#81}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
@ofrobots
Version 5.1.281.70 (cherry-pick)
694b9ce 
Merged 43547df

[crankshaft] Don't inline "dont_crankshaft" functions

BUG=v8:5033
LOG=N
R=hablich@chromium.org, jkummerow@chromium.org

Review URL: https://codereview.chromium.org/2101123004 .

Cr-Commit-Position: refs/branch-heads/5.1@{v8#82}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
@isheludko
Version 5.1.281.71 (cherry-pick)
4bbfab8 
Merged e6076a7

Use proper write barrier mode when creating rest parameters.

BUG=chromium:623912
LOG=N
R=mlippautz@chromium.org

Review URL: https://codereview.chromium.org/2116453002 .

Cr-Commit-Position: refs/branch-heads/5.1@{v8#83}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
Version 5.1.281.71 (cherry-pick)
4531bcf 
Merged 75219da

R=machenbach@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true

PPC64: disable big-array-literal testcase due to stack overflow
Review-Url: https://codereview.chromium.org/2107343002

Cr-Commit-Position: refs/branch-heads/5.1@{v8#84}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
Version 5.1.281.72
d320ab8 
Cr-Commit-Position: refs/branch-heads/5.1@{v8#85}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
@ofrobots
Version 5.1.281.73 (cherry-pick)
42ddece 
Merged 2bcbe2f

switch perf and ll_prof loggers to line buffering

BUG=v8:5015
LOG=N
R=yangguo@chromium.org, hablich@chromium.org, jarin@chromium.org

Review URL: https://codereview.chromium.org/2115943002 .

Cr-Commit-Position: refs/branch-heads/5.1@{v8#86}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
@jaro-sevcik
Version 5.1.281.74 (cherry-pick)
144d2cf 
Merged 7614362

[turbofan] Set elements kind to holey if constructing array of possibly non-zero length.

BUG=chromium:621147
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/2136443003 .

Cr-Commit-Position: refs/branch-heads/5.1@{v8#87}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
@jeisinger
Version 5.1.281.74 (cherry-pick)
6d3d40a 
Merged 46428e4

Make it possible to create a v8::Function directly w/o a prototype

BUG=chromium:625823
LOG=N
TBR=hablich@chromium.org

Review URL: https://codereview.chromium.org/2133643002 .

Cr-Commit-Position: refs/branch-heads/5.1@{v8#88}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mcornac pushed a commit that referenced this issue Apr 18, 2017
Version 5.1.281.75
91b3686 
Cr-Commit-Position: refs/branch-heads/5.1@{v8#89}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
jbajwa pushed a commit that referenced this issue Apr 24, 2017
@mi-ac
Revert of PPC/s390: [ignition] Add call bytecodes for undefined recei…
f7b61ca 
…ver (patchset #1 id:1 of https://codereview.chromium.org/2809743003/ )

Reason for revert:
Need to revert:
https://chromium-review.googlesource.com/c/463287/

Original issue's description:
> PPC/s390: [ignition] Add call bytecodes for undefined receiver
>
> Port 751e893
>
> Original Commit Message:
>
>     Adds a collection of call bytecodes which have an implicit undefined
>     receiver argument, for cases such as global calls where we know that the
>     receiver has to be undefined. This way we can skip an LdaUndefined,
>     decrease bytecode register pressure, and set a more accurate
>     ConvertReceiverMode on the interpreter and TurboFan call.
>
>     As a side effect, the "normal" Call bytecode now becomes a rare case
>     (only with calls and super property calls), so we get rid of its 0-2
>     argument special cases and modify CallProperty[N] to use the
>     NotNullOrUndefined ConvertReceiverMode.
>
> R=leszeks@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
> BUG=
> LOG=N
>
> Review-Url: https://codereview.chromium.org/2809743003
> Cr-Commit-Position: refs/heads/master@{#44539}
> Committed: https://chromium.googlesource.com/v8/v8/+/41b228057f89e73fbaae867177d523e60d4e92bc

TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com,leszeks@chromium.org,michael_dawson@ca.ibm.com,bjaideep@ca.ibm.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2809093002
Cr-Commit-Position: refs/heads/master@{#44546}
jbajwa pushed a commit that referenced this issue Apr 24, 2017
@littledan
Reland of [date] Add ICU backend for timezone info behind a flag (pat…
c1a9e55 
…chset #1 id:1 of https://codereview.chromium.org/2811103002/ )

Reason for revert:
Reland with tests marked as off in no-i18n mode

Original issue's description:
> Revert of [date] Add ICU backend for timezone info behind a flag (patchset #17 id:320001 of https://codereview.chromium.org/2724373002/ )
>
> Reason for revert:
> Breaks noi18n:
> https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/13314
>
> Original issue's description:
> > [date] Add ICU backend for timezone info behind a flag
> >
> > This patch implements a timezone backend which is based on ICU, rather
> > than operating system calls. It can be turned on by passing the
> > --icu-timezone-data flag. The goal here is to take advantage of ICU's
> > data, which is more complete than the data that some system calls expose.
> > For example, without any special code, this patch fixes the time zone
> > of Lord Howe Island to have a correct 30 minute DST offset, rather than
> > 60 minutes as the OS backends assume it to have.
> >
> > Unfortunately, the parenthized timezone name in Date.prototype.toString()
> > differs across platforms. This patch chooses the long timezone name,
> > which matches Windows behavior and might be the most intelligible, but
> > the web compatibility impact is unclear.
> >
> > BUG=v8:6031,v8:2137,v8:6076
> >
> > Review-Url: https://codereview.chromium.org/2724373002
> > Cr-Commit-Position: refs/heads/master@{#44562}
> > Committed: https://chromium.googlesource.com/v8/v8/+/b213f2399038a615cdfbfa0201cddc113d304018
>
> TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:6031,v8:2137,v8:6076
>
> Review-Url: https://codereview.chromium.org/2811103002
> Cr-Commit-Position: refs/heads/master@{#44565}
> Committed: https://chromium.googlesource.com/v8/v8/+/13ad50811024ace5623d5d4d13cea4ef21f4affd

TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,machenbach@chromium.org
BUG=v8:6031,v8:2137,v8:6076

Review-Url: https://codereview.chromium.org/2813863002
Cr-Commit-Position: refs/heads/master@{#44575}
jbajwa pushed a commit that referenced this issue Apr 25, 2017
@hashseed
Revert of [d8] console methods must not throw. (patchset #1 id:1 of h…
95d53ff 
…ttps://codereview.chromium.org/2838143002/ )

Reason for revert:
Breaks no-intl builds.

Original issue's description:
> [d8] console methods must not throw.
>
> R=jarin@chromium.org
> BUG=chromium:714696
>
> Review-Url: https://codereview.chromium.org/2838143002
> Cr-Commit-Position: refs/heads/master@{#44854}
> Committed: https://chromium.googlesource.com/v8/v8/+/87b5b53f6f3321ad33b15e686590da7b57df2ff9

TBR=jarin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:714696

Review-Url: https://codereview.chromium.org/2840853002
Cr-Commit-Position: refs/heads/master@{#44856}
jbajwa pushed a commit that referenced this issue Apr 27, 2017
@camillobruni
Revert of [turbofan] Set proper representation for initial arguments …
6b4b062 
…length. (patchset #1 id:1 of https://codereview.chromium.org/2810333004/ )

Reason for revert:
Field representation is not preserved

Original issue's description:
> [turbofan] Set proper representation for initial arguments length.
>
> The JSArgumentsObject::length representation is initially Smi, so we can
> record that on the initial map and use it to optimize the accesses in
> TurboFan based on that. Similar for JSSloppyArgumentsObject::caller.
>
> BUG=v8:6262
> R=yangguo@chromium.org
>
> Review-Url: https://codereview.chromium.org/2810333004
> Cr-Commit-Position: refs/heads/master@{#44644}
> Committed: https://chromium.googlesource.com/v8/v8/+/5eec7df9b319e5b7a8158d82825d61e90a7cfe33

TBR=yangguo@chromium.org,bmeurer@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:6262

Review-Url: https://codereview.chromium.org/2825323002
Cr-Commit-Position: refs/heads/master@{#44893}
jbajwa pushed a commit that referenced this issue Apr 27, 2017
@schuay
Revert of [turbofan] Fix impossible type handling for TypeGuard and B…
397ebb7 
…ooleanNot. (patchset #1 id:1 of https://codereview.chromium.org/2836203004/ )

Reason for revert:
Tentative revert for https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/14886

Original issue's description:
> [turbofan] Fix impossible type handling for TypeGuard and BooleanNot.
>
> BUG=chromium:715204
>
> Review-Url: https://codereview.chromium.org/2836203004
> Cr-Commit-Position: refs/heads/master@{#44883}
> Committed: https://chromium.googlesource.com/v8/v8/+/9c47a061cf325addf8bd2ba4b71a4d1ef210c5d6

TBR=bmeurer@chromium.org,jarin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:715204

Review-Url: https://codereview.chromium.org/2842793004
Cr-Commit-Position: refs/heads/master@{#44898}
jbajwa pushed a commit that referenced this issue May 4, 2017
@bmeurer
Revert of [tickprocessor] Consider top of the stack as pc if it point…
216e677 
…s to a code object. (patchset #1 id:1 of https://codereview.chromium.org/2822433002/ )

Reason for revert:
Seems to lead to more (completely) misattributed ticks

Original issue's description:
> [tickprocessor] Consider top of the stack as pc if it points to a code object.
>
> Previously, we would only consider it if it pointed to a full-code JS function.
> Thus we could miss both optimized functions and bytecode handlers if they
> called frame-less code.
>
> Review-Url: https://codereview.chromium.org/2822433002
> Cr-Commit-Position: refs/heads/master@{#44640}
> Committed: https://chromium.googlesource.com/v8/v8/+/4433ac299eae30b75357b05dab16d142d239f64e

TBR=jarin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2844053003
Cr-Commit-Position: refs/heads/master@{#44921}
jbajwa pushed a commit that referenced this issue May 4, 2017
Revert of PPC/s390: SmiUntag only for 32bit (patchset #1 id:1 of http…
cef9eff 
…s://codereview.chromium.org/2842843005/ )

Reason for revert:
few tests are failing with stack overflow, will reland with the fix.

Original issue's description:
> PPC/s390: SmiUntag only for 32bit
>
> R=joransiu@ca.ibm.com, jyan@ca.ibm.com
> BUG=
> LOG=n
>
> Review-Url: https://codereview.chromium.org/2842843005
> Cr-Commit-Position: refs/heads/master@{#44908}
> Committed: https://chromium.googlesource.com/v8/v8/+/76dfdb7a32c4be41190ff6a01b23905976e5e0ff

TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2852433002
Cr-Commit-Position: refs/heads/master@{#44936}
jbajwa pushed a commit that referenced this issue May 4, 2017
@bmeurer
Revert of [turbofan] General consolidation of element access. (patchset
53d31d0 
#1 id:1 of https://codereview.chromium.org/2836913004/ )

Reason for revert:
Breaks load:tools:drive story

Original issue's description:
> [turbofan] General consolidation of element access.
>
> Avoid TransitionElementsKind when storing to objects which only differ
> in holeyness of their elements kind. Instead go for polymorphic
> CheckMaps, which can often by optimized and avoid the mutation of the
> array map.
>
> This generalizes the approach https://codereview.chromium.org/2836943003
> which covered only element loads.
>
> R=yangguo@chromium.org
> BUG=v8:5267
>
> Review-Url: https://codereview.chromium.org/2836913004
> Cr-Commit-Position: refs/heads/master@{#44828}
> Committed: https://chromium.googlesource.com/v8/v8/+/ed573cee5c1d1e42158829dc0b92fb697234e121

TBR=yangguo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5267,chromium:715936

Review-Url: https://codereview.chromium.org/2852623002
Cr-Commit-Position: refs/heads/master@{#44958}
jbajwa pushed a commit that referenced this issue May 4, 2017
@alexkozy
[inspector] better stacks for promises
f2bd913 
- we should always set creation async stack if it's available regardless existing of current parent async stack,
- we should cleanup parent link iff there is no creation and schedule async stack for parent.

Let's consider example: Promise.resolve().then(x => x).then(x => x), there is three promises which will call following instrumentation:
1) created #1 (Promise.resolve()) - collected stack #1
2) scheduled #1 - collected stack #2
3) created #2 with #1 as parent (first .then) - collected stack #3
4) created #3 with #2 as parent (first .then) - collected stack #4
5) started #2 - use stack #2 as scheduled
6) scheduled #2 - collected stack #6
7) finished #2
8) started #3 - use stack #6 as scheduled
9) scheduled #3 - collected stack #7
10) finished #3

If we collect stacks between step 4 and 5, it's possible to collect scheduled stack #2 but still have creation stack for #2 - stack #3 - so we always need to add creation event if scheduled is collected.

If we collect stacks between created and scheduled we should not remove parent link even if parent was not scheduled yet.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2844753002
Cr-Commit-Position: refs/heads/master@{#44990}
jbajwa pushed a commit that referenced this issue May 17, 2017
@mi-ac
Revert of [test] add --no-harness option to debugger tests. (patchset #1
2d41b5f 
 id:1 of https://codereview.chromium.org/2831083003/ )

Reason for revert:
Should define its own NO_HARNESS_PATTERN. See comments.

Original issue's description:
> [test] add --no-harness option to debugger tests.
>
> Review-Url: https://codereview.chromium.org/2831083003
> Cr-Commit-Position: refs/heads/master@{#44774}
> Committed: https://chromium.googlesource.com/v8/v8/+/43c20d4cc566c68ce0b566cad0ac6fa92bba8eff

TBR=caitp@igalia.com,yangguo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2871593002
Cr-Commit-Position: refs/heads/master@{#45163}
jbajwa pushed a commit that referenced this issue May 17, 2017
Revert of PPC/s390: Reland: [TypeFeedbackVector] Store optimized code…
c33b25b 
… in the vector (patchset #1 id:1 of https://codereview.chromium.org/2861863003/ )

Reason for revert:
Original CL reverted.
Crashing on Canary
BUG=chromium:718891

Original issue's description:
> PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector
>
> Port 662aa42
>
> Original Commit Message:
>
>     Since the feedback vector is itself a native context structure, why
>     not store optimized code for a function in there rather than in
>     a map from native context to code? This allows us to get rid of
>     the optimized code map in the SharedFunctionInfo, saving a pointer,
>     and making lookup of any optimized code quicker.
>
>     Original patch by Michael Stanton <mvstanton@chromium.org>
>
> R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
> BUG=v8:6246
> LOG=N
>
> Review-Url: https://codereview.chromium.org/2861863003
> Cr-Commit-Position: refs/heads/master@{#45111}
> Committed: https://chromium.googlesource.com/v8/v8/+/d587812258c232f7b9a1f1a9a017ba3f9cea12ea

TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,rmcilroy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:6246

Review-Url: https://codereview.chromium.org/2870703003
Cr-Commit-Position: refs/heads/master@{#45195}
jbajwa pushed a commit that referenced this issue May 17, 2017
@dtig
Revert of [interpreter] Add intrinsics for map/set instance type chec…
386cd83 
…ks (patchset #1 id:1 of https://codereview.chromium.org/2868343002/ )

Reason for revert:
Breaks V8 Linux - arm64 - sim - gc stress -

https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/6471/steps/Bisect%20f86985ad.Retry/logs/typedarray-every

Original issue's description:
> [interpreter] Add intrinsics for map/set instance type checks
>
> BUG=v8:6261, v8:6278, v8:6344
>
> Review-Url: https://codereview.chromium.org/2868343002
> Cr-Commit-Position: refs/heads/master@{#45236}
> Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a24baa

TBR=rmcilroy@chromium.org,gsathya@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6261, v8:6278, v8:6344

Review-Url: https://codereview.chromium.org/2878473002
Cr-Commit-Position: refs/heads/master@{#45239}
jbajwa pushed a commit that referenced this issue May 19, 2017
@mmc28a
Revert of Add DEPS.chromium for recursive DEPS tracking. (patchset #1 …
822442f 
…id:1 of https://codereview.chromium.org/2880293002/ )

Reason for revert:
Going a different way with this, as Chromium don't want the additional files.

Original issue's description:
> Add DEPS.chromium for recursive DEPS tracking.
>
> DEPS.chromium allows the Chromium build system's DEPS to recurse into V8's own
> dependencies. Initially, this is populated with some tests files for the ARM64
> simulator.
>
> BUG=chromium:718439
>
> Review-Url: https://codereview.chromium.org/2880293002
> Cr-Commit-Position: refs/heads/master@{#45310}
> Committed: https://chromium.googlesource.com/v8/v8/+/f8a6c6c48e79ef4267d03c80aa768e8362341e4a

TBR=machenbach@chromium.org,bmeurer@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:718439

Review-Url: https://codereview.chromium.org/2891323002
Cr-Commit-Position: refs/heads/master@{#45420}
jbajwa pushed a commit that referenced this issue May 24, 2017
@mi-ac
Revert of [turbofan] Speculatively optimize string character access. …
a07218a 
…(patchset #1 id:1 of https://codereview.chromium.org/2905623003/ )

Reason for revert:
Changes layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/15867

See:
https://github.com/v8/v8/wiki/Blink-layout-tests

Original issue's description:
> [turbofan] Speculatively optimize string character access.
>
> Add a protector cell for string bounds checks that is being used to
> protect speculative bounds for String.prototype.charCodeAt and
> String.prototype.charAt in TurboFan (and Crankshaft). This way we don't
> have the diamond in optimized code, which stands in the way of other
> optimizations for charCodeAt that are currently being worked on by
> petermarshall@.
>
> BUG=v8:6391
> TBR=mlippautz@chromium.org
> R=petermarshall@chromium.org
>
> Review-Url: https://codereview.chromium.org/2905623003
> Cr-Commit-Position: refs/heads/master@{#45514}
> Committed: https://chromium.googlesource.com/v8/v8/+/9d8bd0551657d60c66b2f96544eecedfba1cba8a

TBR=petermarshall@chromium.org,mlippautz@chromium.org,bmeurer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6391

Review-Url: https://codereview.chromium.org/2900333002
Cr-Commit-Position: refs/heads/master@{#45521}
jbajwa pushed a commit that referenced this issue Jul 5, 2017
@bmeurer
Revert of [turbofan] Extend escape analysis to reduce certain CheckMa…
9e7b928 
…ps. (patchset #1 id:1 of https://codereview.chromium.org/2964473002/ )

Reason for revert:
Speculative revert for tiny fire on Canary (crbug.com/738781)

Original issue's description:
> [turbofan] Extend escape analysis to reduce certain CheckMaps.
>
> Enable the experimental support in escape analysis to deal with
> constant-foldable CheckMaps nodes and remove them from the effect
> chain w/o blocking the scalar replacement of the object.
>
> BUG=v8:4586,v8:5267
> R=tebbi@chromium.org
>
> Review-Url: https://codereview.chromium.org/2964473002
> Cr-Commit-Position: refs/heads/master@{#46311}
> Committed: https://chromium.googlesource.com/v8/v8/+/adf7f54e24c4b31207b4df0e30c28f7579b18f5c

TBR=tebbi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:4586,v8:5267

Review-Url: https://codereview.chromium.org/2970663002
Cr-Commit-Position: refs/heads/master@{#46372}
jbajwa pushed a commit that referenced this issue Jul 24, 2017
@backes
Revert of [api] Fix compilation error for UNIMPLEMENTED() method (p…
395ca78 
…atchset #1 id:1 of https://codereview.chromium.org/2929993003/ )

Reason for revert:
not needed any more, and contradicts our cleanup efforts: https://chromium-review.googlesource.com/c/507287/

Original issue's description:
> [api] Fix compilation error for `UNIMPLEMENTED()` method
>
> Return `nullptr` from `ArrayBuffer::Allocator::Reserve` because
> apparently not doing so results in compile errors for some people.
>
> BUG=
>
> Ref: nodejs/node#13392
> Review-Url: https://codereview.chromium.org/2929993003
> Cr-Commit-Position: refs/heads/master@{#45886}
> Committed: https://chromium.googlesource.com/v8/v8/+/f14d1b62313329f421f12cae429673c1b13018f9

R=franzih@chromium.org,addaleax@gmail.com

Review-Url: https://codereview.chromium.org/2946933002
Cr-Commit-Position: refs/heads/master@{#46739}
jbajwa pushed a commit that referenced this issue Sep 6, 2017
@KarlSchimpf
Make sure function size UMA stat is collected.
8b865c8 
This fixes the collection of function sizes (see comment #1 of
v8:6361).  This was done by adding a wrapper function around
VerifyWasmCode() that updates UMA stats for function size (as well as
decode time when validating).

Bug: v8:6361
Change-Id: Ia2597db22cbed5b0429d9c8514e96cdea5d7323a
Reviewed-on: https://chromium-review.googlesource.com/600530
Commit-Queue: Karl Schimpf <kschimpf@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47147}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbajwa jbajwa

Labels
5.3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbajwa @joransiu