Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the docs and ux #99

Closed
wants to merge 6 commits into from
Closed

Conversation

BShrivastav
Copy link

@BShrivastav BShrivastav commented Mar 1, 2022

NOTE: updated for access_tags and ipv4_cidr_block

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000
https://jiracloud.swg.usma.ibm.com:8443/browse/UI-21204
Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Copy link
Collaborator

@uibm uibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consolidate both prs into one

@@ -111,7 +111,17 @@ In addition to all argument reference list, you can access the following attribu
- `profile` - (String) The name for this bare metal server profile
- `resource_group` - (String) resource group id of the bare metal server.
- `resource_type` - (String) The type of resource referenced
- `status` - (String) The status of the bare metal server [ **failed**, **pending**, **restarting**, **running**, **starting**, **stopped**, **stopping** ]
- `status` - (String) The status of the bare metal server.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify the below design with Harini if content team is fine, rest LGTM.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed, and she agreed.

Copy link
Collaborator

@sumitkumartiwari sumitkumartiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment, good to go upstream.

@BShrivastav BShrivastav changed the title Updated the Notes section of subnet (resource documentation) Updated the docs and ux Apr 19, 2023
@BShrivastav BShrivastav force-pushed the subnet-rdoc-correction branch from 0c85081 to 6eb5972 Compare April 19, 2023 06:20
@BShrivastav BShrivastav force-pushed the subnet-rdoc-correction branch from 6eb5972 to 2d731b9 Compare April 19, 2023 06:25
@BShrivastav
Copy link
Author

Closing as Upstream is raised: IBM-Cloud#4529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants