Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Over Count Bug Fix #165

Closed
wants to merge 1 commit into from
Closed

Delete Over Count Bug Fix #165

wants to merge 1 commit into from

Conversation

SunithaGudisagarIBM
Copy link

Please refer here for test results
IBM-Cloud#3946

BShrivastav
BShrivastav suggested changes Aug 9, 2022
View reviewed changes
Copy link

@BShrivastav BShrivastav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need changes in the documentations for plan as it is integer field, to help user to set it to null for a patch operation when the delete_over_count field is preset to some value.


  deletion_trigger {
    delete_after = 2
    delete_over_count = "null"
  }

@SunithaGudisagarIBM SunithaGudisagarIBM force-pushed the bugfix-is-baas branch 3 times, most recently from fdb9a1c to 73a5324 Compare August 12, 2022 07:53
BShrivastav
BShrivastav approved these changes Aug 12, 2022
View reviewed changes
Copy link

@BShrivastav BShrivastav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, this works as per riaas API Specs.

@SunithaGudisagarIBM SunithaGudisagarIBM mentioned this pull request Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BShrivastav BShrivastav BShrivastav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunithaGudisagarIBM @BShrivastav @SunithaGudisagarIBM1