Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Remove custom service account secrets when a cluster is deprovisioned #1417

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

ashleytate614
Copy link
Contributor

Issue

https://jsw.ibm.com/browse/MASCORE-4479

Details

Update the gitops_deprovision_cluster function to remove custom service account secrets from AWS Secrets Manager.

Copy link
Contributor

@tomklapiscak tomklapiscak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please post a quick summary of the testing you performed.

image/cli/mascli/functions/gitops_deprovision_cluster Outdated Show resolved Hide resolved
@tomklapiscak
Copy link
Contributor

Also, you'll need to get an approval from one of the listed code owners before this PR can be merged.

@sanjayprab sanjayprab merged commit e12610f into master Dec 23, 2024
12 checks passed
@sanjayprab sanjayprab deleted the mascore-4479-3 branch December 23, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants