Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] MAS Cluster Issuer python args and COS params updates for Manage #1404

Merged
merged 68 commits into from
Dec 19, 2024

Conversation

leo-miran
Copy link
Contributor

@leo-miran leo-miran commented Dec 12, 2024

This PR introduces new args that enables certificates configuration when using cluster issuer settings for MAS Core install and new vars to support attachment configuration during Manage post install config steps. Also adding new dependency for Manage Install on cos install and configure tasks.

Important This pr depends on the following python-devops pr: ibm-mas/python-devops#49

  • MAS Cluster Issuer argument added so that CIS_EMAIL is set accordingly
masAdvancedArgGroup.add_argument(
    "--mas-cluster-issuer",
    dest="mas_cluster_issuer",
    required=False,
    help="Only required if you want to use Let's Encrypt certificates in your MAS installation",
)
  • Manage Attachment configuration arguments
manageArgGroup.add_argument(
    "--mas-manage-attachments-provider",
    dest="mas_manage_attachments_provider",
    required=False,
    help="Defines the storage provider type to be used to store Manage application's attachments."
)
manageArgGroup.add_argument(
    "--mas-manage-attachment-configuration-mode",
    dest="mas_manage_attachment_configuration_mode",
    required=False,
    help="Defines how attachment properties will be configured in Manage. Possible values are: cr and db"
)
  • Cloud Object Storage (COS) arguments used for instance and bucket configuration
cosArgGroup.add_argument(
    "--cos-instance-name",
    dest="cos_instance_name",
    required=False,
    help="When using IBM COS, set COS instance name to be used/created"
)
cosArgGroup.add_argument(
    "--cos-bucket-name",
    dest="cos_bucket_name",
    required=False,
    help="When using IBM COS, set COS bucket name to be used/created"
)
  • Tests Evidences
    Successful run where these values have been set and manually verified to be working
    image

  • MAS Cluster Issuer certificates
    image

  • COS Instance and Bucket created and Manage attachment config also completed
    image
    image

  • New Manage install dependency on COS install and config task
    image

@leo-miran leo-miran marked this pull request as draft December 17, 2024 21:08
@leo-miran leo-miran marked this pull request as ready for review December 18, 2024 01:07
@leo-miran leo-miran marked this pull request as draft December 18, 2024 20:38
@leo-miran leo-miran changed the title [patch] MAS Cluster Issuer python args and COS params updates for Manage. [patch] MAS Cluster Issuer python args and COS params updates for Manage Dec 19, 2024
@leo-miran leo-miran marked this pull request as ready for review December 19, 2024 01:32
durera
durera previously approved these changes Dec 19, 2024
@durera durera merged commit 300b195 into master Dec 19, 2024
12 checks passed
@durera durera deleted the cissuer branch December 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants