-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] MAS Cluster Issuer python args and COS params updates for Manage #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-miran
requested review from
durera,
JonahLuckett,
andrercm,
sanjayprab,
terenceq,
whitfiea and
alequint
as code owners
December 17, 2024 13:14
leo-miran
changed the title
[patch] MAS Cluster Issuer python args and COS params updates for Manage.
[patch] MAS Cluster Issuer python args and COS params updates for Manage
Dec 19, 2024
durera
previously approved these changes
Dec 19, 2024
durera
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new args that enables certificates configuration when using cluster issuer settings for MAS Core install and new vars to support attachment configuration during Manage post install config steps. Also adding new dependency for Manage Install on
cos install
andconfigure
tasks.Important This pr depends on the following python-devops pr: ibm-mas/python-devops#49
Tests Evidences
Successful run where these values have been set and manually verified to be working
MAS Cluster Issuer certificates
COS Instance and Bucket created and Manage attachment config also completed
New Manage install dependency on COS install and config task