Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: add upper-bound to BigQuery dependency #2426

Merged

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Oct 1, 2020

There are breaking changes in google-cloud-bigquery 2.0 that aren't
handled yet. Also, 2.0 seems to require a newer version of the protobuf
library than is available in CI.

Closes #2413

@jreback jreback added this to the Next Bugfix Release milestone Oct 1, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, ping on green

@tswast
Copy link
Collaborator Author

tswast commented Oct 1, 2020

Not sure why I'm getting an older version of protobuf even when I specify a minimum version in the YAML.

https://github.com/ibis-project/ibis/pull/2426/checks?check_run_id=1194407579#step:6:1217

9504d4e

google-cloud-bigquery>=1.12.0
pydata-google-auth
google-cloud-bigquery>=1.12.0,<2.0.0dev
protobuf>=3.12.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not a transitive dep?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is google-cloud-bigquery -> google-api-core -> protobuf. Added to see if that prevented getting too old of a version in CI, but seems I actually needed to update the recipe here: conda-forge/ibis-framework-feedstock#48

Will remove in my next commit.

pydata-google-auth
google-cloud-bigquery>=1.12.0,<2.0.0dev
protobuf>=3.12.0
pydata-google-auth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline

@jreback
Copy link
Contributor

jreback commented Oct 1, 2020

@jreback
Copy link
Contributor

jreback commented Oct 1, 2020

ok merged the conda-forge PR, I think we need to wait for builds then rebase this

There are breaking changes in `google-cloud-bigquery` 2.0 that aren't
handled yet. Also, 2.0 seems to require a newer version of the protobuf
library than is available in CI.
@tswast tswast force-pushed the issue2413-bigquery-upper-bound branch from 1785010 to 2e65db7 Compare October 2, 2020 14:24
@datapythonista
Copy link
Contributor

It's a bit strange, it's failing because the moved omnisci backend, but that was updated in conda-forge/ibis-framework-feedstock#47 already.

Traceback (most recent call last):
  File "/usr/share/miniconda/conda-bld/ibis-framework_1601657511591/test_tmp/run_test.py", line 26, in <module>
    import ibis.omniscidb
ModuleNotFoundError: No module named 'ibis.omniscidb'

@datapythonista
Copy link
Contributor

Oh, I see that you reverted that @tswast. Can the OmniSci module be set to the correct module again?

@datapythonista
Copy link
Contributor

I opened conda-forge/ibis-framework-feedstock#50, I guess with the two PRs, the CI should be fixed.

@jreback
Copy link
Contributor

jreback commented Oct 2, 2020

yeah let's try to get a green build with the updated packages that @tswast triggered now. Then let's disable this job for now; we really only care about this on release, BUT it is good to test it all the time, so need a better way.

@datapythonista
Copy link
Contributor

Merging this, will disable the conda packaging in a follow up, so we have a green CI while we decide how to deal with the recipe.

@datapythonista datapythonista merged commit 98e0ac0 into ibis-project:master Oct 2, 2020
@datapythonista
Copy link
Contributor

Thanks @tswast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix bigquery version
3 participants