-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: add upper-bound to BigQuery dependency #2426
BUG: add upper-bound to BigQuery dependency #2426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, ping on green
Not sure why I'm getting an older version of protobuf even when I specify a minimum version in the YAML. https://github.com/ibis-project/ibis/pull/2426/checks?check_run_id=1194407579#step:6:1217 |
ci/deps/bigquery.yml
Outdated
google-cloud-bigquery>=1.12.0 | ||
pydata-google-auth | ||
google-cloud-bigquery>=1.12.0,<2.0.0dev | ||
protobuf>=3.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this not a transitive dep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is google-cloud-bigquery -> google-api-core -> protobuf
. Added to see if that prevented getting too old of a version in CI, but seems I actually needed to update the recipe here: conda-forge/ibis-framework-feedstock#48
Will remove in my next commit.
ci/deps/bigquery.yml
Outdated
pydata-google-auth | ||
google-cloud-bigquery>=1.12.0,<2.0.0dev | ||
protobuf>=3.12.0 | ||
pydata-google-auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a newline
I see conda-forge/ibis-framework-feedstock#48 thanks @tswast |
ok merged the conda-forge PR, I think we need to wait for builds then rebase this |
There are breaking changes in `google-cloud-bigquery` 2.0 that aren't handled yet. Also, 2.0 seems to require a newer version of the protobuf library than is available in CI.
1785010
to
2e65db7
Compare
It's a bit strange, it's failing because the moved omnisci backend, but that was updated in conda-forge/ibis-framework-feedstock#47 already.
|
Oh, I see that you reverted that @tswast. Can the OmniSci module be set to the correct module again? |
I opened conda-forge/ibis-framework-feedstock#50, I guess with the two PRs, the CI should be fixed. |
yeah let's try to get a green build with the updated packages that @tswast triggered now. Then let's disable this job for now; we really only care about this on release, BUT it is good to test it all the time, so need a better way. |
Merging this, will disable the conda packaging in a follow up, so we have a green CI while we decide how to deal with the recipe. |
Thanks @tswast |
There are breaking changes in
google-cloud-bigquery
2.0 that aren'thandled yet. Also, 2.0 seems to require a newer version of the protobuf
library than is available in CI.
Closes #2413