Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPP: Fix smoke test for geo spatial operations #1929

Closed
2 tasks
xmnlab opened this issue Aug 19, 2019 · 0 comments · Fixed by #1928
Closed
2 tasks

SUPP: Fix smoke test for geo spatial operations #1929

xmnlab opened this issue Aug 19, 2019 · 0 comments · Fixed by #1928
Assignees
@xmnlab
Labels
refactor Issues or PRs related to refactoring the codebase tests Issues or PRs related to tests

Comments

@xmnlab
Copy link
Contributor

xmnlab commented Aug 19, 2019

Improve smoke test for geospatial operations:
@xmnlab xmnlab added refactor Issues or PRs related to refactoring the codebase tests Issues or PRs related to tests postgis labels Aug 19, 2019
@xmnlab xmnlab self-assigned this Aug 19, 2019
This was referenced Aug 19, 2019
Merged
Closed
@xmnlab xmnlab changed the title Fix smoke test for geo spatial operations SUPP: Fix smoke test for geo spatial operations Aug 20, 2019
cpcloud pushed a commit that referenced this issue Aug 26, 2019
@xmnlab @cpcloud
SUPP: Improve geospatial literals and smoke tests
7c032e0 
Improves geo spatial literals and smoke tests:    - changes
`GeoMockConnection` to allow tests for `omniscid` to `postgresql`
https://github.com/ibis-
project/ibis/blob/master/ibis/expr/tests/mocks.py#L423  - fixes geo
spatial literals used in https://github.com/ibis-
project/ibis/blob/master/ibis/expr/tests/test_geospatial.py  - improve
tests in https://github.com/ibis-
project/ibis/blob/master/ibis/expr/tests/test_geospatial.py  - fixes
black pre-commit hook configuration  - allows literal without
geo_types (geometry or geography) for `postgis` backend  - fixes
translation for geo spatial literals (ibis/common/geospatial.py)
Resolves #1929  Resolves #1931  Resolves partially #1930
Author: Ivan Ogasawara <ivan.ogasawara@gmail.com>

Closes #1928 from xmnlab/change-geo-mock-test-backend and squashes the following commits:

9aac60c [Ivan Ogasawara] Added an assert for test_geo_ops_smoke
7acb69f [Ivan Ogasawara] Fixed smoke test for geospatial operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmnlab xmnlab

Labels
refactor Issues or PRs related to refactoring the codebase tests Issues or PRs related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SUPP: Improve geospatial literals and smoke tests Quansight/ibis
1 participant
@xmnlab