Add support for lower- or mixed-cased values on environment variables #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found out that the code doesn't handle overrides (like |
|
Thanks for putting this together, I've landed it in 2.0.1. |
iarna
added a commit
to npm/npm
that referenced
this pull request
Jun 24, 2016
Fix unicode dection on a number of Linux distributions. Credit: @Darkhogg Credit: @gagern Reviewed-By: @iarna PR-URL: iarna/has-unicode#3 PR-URL: iarna/has-unicode#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my current Linux installation (Manjaro, installed two years ago) the variable
LANGreports a value ofen_US.utf8, with that exact case. This made this package detect my system as not supporting UTF-8 and therefore some applications (particularlynpm) don't use their nicer display modes. This pull request addresses this by making all checks case-agnostic.It also includes tests for lowercase strings, and I've added a missing test for the
LC_CTYPEvariable, which was missing.This addresses #2