Fix IME input not work #880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pizn I don't know enough about IME to get it to work reliably. I'm open to a pull request to completely fix IME, but I'd rather have it done all in one go, and I'm not sure if this does it? If you're up for making that kind of PR, that would be awesome, I'd need you to add a lot more information so that I can be more sure of merging it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I just wanted to closes #879 , but I found is the wrong way.
I found when use IME input, while the state is updated but react did not render the current DOM. And it really need to re-render when onCompositionEnd to update the forceKey. But not enough, I have to use forceUpdate() to update the DOM.
It can fixed #871 #875 #844