Gives a warning when visiting editor.value during onChange

[zhujinxuan]

Is this adding or improving a feature or fixing a bug?

perhaps a bug; Editor run into a runaway recursion when visiting editor.value during onChange
#2152

What's the new behavior?

1. Allows user visit editor.value during onChange.
2. Gives a warning when user do it.

How does this change work?

Adds tmp.isResolvingValue in editor

Have you checked that...?

• The new code matches the existing patterns and styles.
• The tests pass with yarn test.
• The linter passes with yarn lint. (Fix errors with yarn prettier.)
• The relevant examples still work. (Run examples with yarn watch.)

Does this fix any issues or need any specific reviewers?

Fixes: #2152
Reviewers: @ericedem

[ericedem]

I'm not sure I understand. Is the API user supposed to be only calling editor.props.value? How could the user know that there is a change being resolved in order to call the right one?

It seems like the user shouldn't be calling editor.value at all?

[zhujinxuan]

@ericedem You can call editor.value with onEvent like onKeyDown, but not with onChange

@ianstormtaylor Shall we break onChange with onNormalization and onChange? It seems a bit confusing with the name onChange which appears like onEvent. But it is perhaps unwise to access editor.XXX during onChange

[ericedem]

@zhujinxuan What benefit is there to calling editor.value in an event handler as opposed to editor.props.value? Isn't the value guaranteed to be normalized in handlers (except onChange)?

[zhujinxuan]

@ericedem I think it shall be called in renderEditor. For example, given the current mark, which mark buttons shall be shown active in toolbar or hovering menu. Another possibility is, if setTimeout or requestAnimation is called, we may need to access editor.value in the callback.

…

On Mon, Sep 10, 2018 at 16:41 Eric Edem ***@***.***> wrote: @zhujinxuan <https://github.com/zhujinxuan> What benefit is there to calling editor.value in an event handler as opposed to editor.props.value? Isn't the value guaranteed to be normalized in handlers (except onChange)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2165 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAtir2YhWmeQOy6lZ6IBK9vWOB6l6nW3ks5uZs5ogaJpZM4Whh87> .