Define NODE_ENV to use the production build of React on slatejs.org #1939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Improvement
What's the new behavior?
Defines
process.env.NODE_ENV
through webpack'sDefinePlugin
. Defining this value causes us to use the production build of React on slatejs.org, which has better performance (and is thus a better representation of how Slate works, especially with large documents).Specifically -- defining
process.env.NODE_ENV
makes code paths unreachable within the core React code (by producing, in essence,true === false
conditionals), and then Uglify strips out those unreachable code paths, resulting in React not running development code and being faster.How does this change work?
See previous section
Have you checked that...?
yarn test
.yarn lint
. (Fix errors withyarn prettier
.)yarn watch
.)Does this fix any issues or need any specific reviewers?
Reviewers: @ianstormtaylor