Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update wrong char in Ukranian [uk] locale #1449

Closed

Conversation

aloisklink
Copy link
Contributor

Tests were failing because the Ukranian month for April (квіт) was written using i (0x69) not і (0x456)

They look exactly the same, but === thinks they are different.

Failing Test

Summary of all failing tests
 FAIL  test/locale/uk.test.js
  ● Format Month with locale function

    expect(received).toEqual(expected)
    
    Expected value to equal:
      "09 квітня 2021 квіт"
    Received:
      "09 квітня 2021 квiт"

      22 |     const testFormat2 = 'MMMM'
      23 |     const testFormat3 = 'MMM'
    > 24 |     expect(dayjsUK.format(testFormat1)).toEqual(momentUK.format(testFormat1))
      25 |     expect(dayjsUK.format(testFormat2)).toEqual(momentUK.format(testFormat2))
      26 |     expect(dayjsUK.format(testFormat3)).toEqual(momentUK.format(testFormat3))
      27 |   }
      
      at Object.<anonymous> (test/locale/uk.test.js:24:41)

Tests were failing because the Ukranian month for April
(квіт) was written using i (0x69) not і (0x456)
@aloisklink
Copy link
Contributor Author

It looks like this has already been fixed by #1463.

@aloisklink aloisklink closed this Apr 23, 2021
@iamkun
Copy link
Owner

iamkun commented Apr 23, 2021

Thanks

@aloisklink aloisklink deleted the fix-ukranian-incorrect-char branch December 9, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants