Skip to content

Commit

Permalink
Add types to exports (fixes issue muratgozel#38 for ES imports)
Browse files Browse the repository at this point in the history
See TypeScript issue here: microsoft/TypeScript#52363
I don't entirely follow what TS is doing, but I've based this commit on a PR
linked from that discussion: gxmari007/vite-plugin-eslint#60

I don't think this will work for CJS imports as TS seems to be pedantic around
file suffixes -- we may need to copy or wrap the .d.ts file somehow.
I'll investigate that separately.
  • Loading branch information
iainmerrick committed Oct 12, 2023
1 parent 4129dd5 commit 99dd9b4
Showing 1 changed file with 17 additions and 5 deletions.
22 changes: 17 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,33 @@
"exports": {
".": {
"node": {
"import": "./dist/node/mimetext.es.js",
"import": {
"types": "./types/index.d.ts",
"default": "./dist/node/mimetext.es.js"
},
"require": "./dist/node/mimetext.cjs",
"default": "./dist/node/mimetext.cjs"
},
"import": "./dist/browser/mimetext.es.js",
"import": {
"types": "./types/index.d.ts",
"default": "./dist/browser/mimetext.es.js"
},
"require": "./dist/browser/mimetext.cjs",
"default": "./dist/browser/mimetext.cjs"
},
"./browser": {
"import": "./dist/browser/mimetext.es.js",
"import": {
"types": "./types/index.d.ts",
"default": "./dist/browser/mimetext.es.js"
},
"require": "./dist/browser/mimetext.cjs",
"default": "./dist/browser/mimetext.cjs"
},
"./node": {
"import": "./dist/node/mimetext.es.js",
"import": {
"types": "./types/index.d.ts",
"default": "./dist/node/mimetext.es.js"
},
"require": "./dist/node/mimetext.cjs",
"default": "./dist/node/mimetext.cjs"
},
Expand Down Expand Up @@ -97,4 +109,4 @@
"overrides": {
"xml2js": "0.5.0"
}
}
}

0 comments on commit 99dd9b4

Please sign in to comment.