Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grouping&Mapping] accessToken parameter now takes a callback fn #285

Merged
merged 20 commits into from
Jun 23, 2022
Merged

[Grouping&Mapping] accessToken parameter now takes a callback fn #285

merged 20 commits into from
Jun 23, 2022

Conversation

Guillar1
Copy link
Contributor

accessToken now takes a callback function.

@Guillar1 Guillar1 requested review from a team, arnobmallickbsw and bingjiez as code owners June 21, 2022 01:22
@Guillar1 Guillar1 changed the title [Grouping&Mapping] accessToken parameter is now a callback fn [Grouping&Mapping] accessToken parameter now takes a callback fn Jun 21, 2022
@Guillar1
Copy link
Contributor Author

Guillar1 commented Jun 23, 2022 •
edited
Loading

@aruniverse I've added @MindaugasButkus to codeowners. Needs approval. Thanks.

@aruniverse
Copy link
Member

please have @MindaugasButkus approve before merging

MindaugasButkus
MindaugasButkus approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@MindaugasButkus MindaugasButkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Guillar1 Guillar1 merged commit 9258e2d into master Jun 23, 2022
@Guillar1 Guillar1 deleted the token-callback branch June 23, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse approved these changes

@MindaugasButkus MindaugasButkus MindaugasButkus approved these changes

@arnobmallickbsw arnobmallickbsw Awaiting requested review from arnobmallickbsw

@bingjiez bingjiez Awaiting requested review from bingjiez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Guillar1 @aruniverse @MindaugasButkus