Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for deletion-detect algorithm #16

Merged
merged 10 commits into from
Dec 17, 2021
Merged

Fixes for deletion-detect algorithm #16

merged 10 commits into from
Dec 17, 2021

Conversation

ziyzhu
Copy link
Contributor

@ziyzhu ziyzhu commented Dec 16, 2021 •
edited
Loading

  1. A continuation of Handle ElementUniqueAspect #15. This PR adds support to detect deleted ElementUniqueAspects. The provenances of them are stored as ExternalSourceAspects on their attached Elements.
  2. Fixed the deletion algorithm to only delete EC instances under the current job Subject (sometimes also referred to as a channel).

Special things about ElementAspect:

  1. ElementAspect shares the same ECInstanceID as its attached Element.
  2. ElementAspects are not owned by any Models nor Subjects.

@ziyzhu ziyzhu marked this pull request as ready for review December 17, 2021 01:06
@ziyzhu ziyzhu changed the title Fix for ElementUniqueAspect deletion Fixes for deletion-detect algorithm Dec 17, 2021
@ziyzhu ziyzhu merged commit 91ddcc3 into main Dec 17, 2021
@ziyzhu ziyzhu deleted the aspect-delete branch December 17, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ziyzhu