Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test apps #7684

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Fix test apps #7684

merged 5 commits into from
Feb 11, 2025

Conversation

pmconne
Copy link
Member

@pmconne pmconne commented Feb 10, 2025

React to accumulated compilation errors in display-test-app and display-performance-test-app caused by #7683.
We need to fix that issue to prevent new compilation errors from being introduced.

@pmconne pmconne requested review from bbastings and a team as code owners February 10, 2025 18:58
@pmconne pmconne enabled auto-merge (squash) February 10, 2025 18:58
aruniverse
aruniverse reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in pkg.json can you update the build:frontend command to run tsc?

test-apps/display-test-app/src/frontend/OutputShadersTool.ts Outdated Show resolved Hide resolved
test-apps/display-test-app/src/frontend/TileContentTool.ts Outdated Show resolved Hide resolved
test-apps/display-test-app/src/frontend/TileSizeRecorder.ts Outdated Show resolved Hide resolved
@pmconne
Copy link
Member Author

pmconne commented Feb 10, 2025 •
edited
Loading

in pkg.json can you update the build:frontend command to run tsc?

It already does. The build script does not run build:frontend, it runs build:frontend-vite which runs vite build. So rush build never invokes tsc.

tcobbs-bentley
tcobbs-bentley approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@tcobbs-bentley tcobbs-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the cjs/esm stuff, but everything else looks ok to me.

@pmconne pmconne merged commit a112d26 into master Feb 11, 2025
16 checks passed
@pmconne pmconne deleted the pmc/fix-display-test-app-compilation-errors branch February 11, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse approved these changes

@markschlosseratbentley markschlosseratbentley markschlosseratbentley approved these changes

@bbastings bbastings bbastings approved these changes

@tcobbs-bentley tcobbs-bentley tcobbs-bentley approved these changes

@ben-polinsky ben-polinsky Awaiting requested review from ben-polinsky ben-polinsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmconne @aruniverse @markschlosseratbentley @bbastings @tcobbs-bentley