Change implementation of the .las parser #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
953a30a to
f36db2b
Compare
Merged
jailln
reviewed
Jan 23, 2024
jailln
approved these changes
Jan 24, 2024
598d070 to
6e81d63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the implementation of the gestion of copc, we need to integretate a parsing methode for las v1.4 or curretnly the las Parser used (loaders.gl/las) only follow the specification of las v1.2, and is not going to evolve in a near future.
The copc.js module (that will be really handy for the copc gestion) on the other hand manage the las v1.4 and bellow.
This PR aims to change the las parser from the loader.gl library to the copc library.