feature(core): doesn't clean depth buffer when needed.

iTowns · Jun 21, 2019 · 3a8daf0 · 3a8daf0
1 parent 3ac9394
commit 3a8daf0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 19 deletions.
diff --git a/src/Core/Prefab/GlobeView.js b/src/Core/Prefab/GlobeView.js
@@ -1,7 +1,6 @@
 import * as THREE from 'three';
 
 import View, { VIEW_EVENTS } from 'Core/View';
-import { MAIN_LOOP_EVENTS } from 'Core/MainLoop';
 import GlobeControls from 'Controls/GlobeControls';
 
 import GlobeLayer from 'Core/Prefab/Globe/GlobeLayer';
@@ -125,15 +124,6 @@ class GlobeView extends View {
             this.controls.handleCollision = typeof (options.handleCollision) !== 'undefined' ? options.handleCollision : true;
         }
 
-        this._fullSizeDepthBuffer = null;
-
-        this.addFrameRequester(MAIN_LOOP_EVENTS.BEFORE_RENDER, () => {
-            if (this._fullSizeDepthBuffer != null) {
-                // clean depth buffer
-                this._fullSizeDepthBuffer = null;
-            }
-        });
-
         this.tileLayer = tileLayer;
 
         this.addLayer(new Atmosphere());

diff --git a/src/Core/Prefab/PlanarView.js b/src/Core/Prefab/PlanarView.js
@@ -1,7 +1,6 @@
 import * as THREE from 'three';
 
 import View from 'Core/View';
-import { MAIN_LOOP_EVENTS } from 'Core/MainLoop';
 import CameraUtils from 'Utils/CameraUtils';
 
 import PlanarLayer from './Planar/PlanarLayer';
@@ -28,14 +27,6 @@ class PlanarView extends View {
         const p = { coord: extent.center(), range: max, tilt: 20, heading: 0 };
         CameraUtils.transformCameraToLookAtTarget(this, camera3D, p);
 
-        this._fullSizeDepthBuffer = null;
-        this.addFrameRequester(MAIN_LOOP_EVENTS.BEFORE_RENDER, () => {
-            if (this._fullSizeDepthBuffer != null) {
-                // clean depth buffer
-                this._fullSizeDepthBuffer = null;
-            }
-        });
-
         this.tileLayer = tileLayer;
     }
 

diff --git a/src/Core/View.js b/src/Core/View.js
@@ -175,6 +175,15 @@ class View extends THREE.EventDispatcher {
         };
 
         this.addEventListener(VIEW_EVENTS.LAYERS_INITIALIZED, fn);
+
+        this._fullSizeDepthBuffer = null;
+
+        this.addFrameRequester(MAIN_LOOP_EVENTS.BEFORE_RENDER, () => {
+            if (this._fullSizeDepthBuffer != null && this._fullSizeDepthBuffer.needsUpdate) {
+                // clean depth buffer
+                this._fullSizeDepthBuffer = null;
+            }
+        });
     }
 
 
@@ -313,6 +322,9 @@ class View extends THREE.EventDispatcher {
     notifyChange(changeSource = undefined, needsRedraw = true) {
         if (changeSource) {
             this._changeSources.add(changeSource);
+            if ((changeSource.isTileMesh || changeSource.isCamera) && this._fullSizeDepthBuffer) {
+                this._fullSizeDepthBuffer.needsUpdate = true;
+            }
         }
         this.mainLoop.scheduleViewUpdate(this, needsRedraw);
     }