moved logic from modal to primary buttons #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚅 Previously deployed to Railway in the iNZight Lite project. Environment has been deleted. |
|
At this stage, the behavior is as before, with the only indication that something has happened being the (undesired) disappearance of the trend lines. But, I suppose, it's a slight improvement ... |
tmelliott
added a commit
that referenced
this pull request
Dec 31, 2024
* url-import var fix (#367) * feat(ui): Only display ticker on targeted URLs * feat(ui): Display extra build info * check for null hostname * display hostname, update version * use userData * use url_hostname * wrap with observe() * remove debug * Features/update inzighttools (#368) * update iNZightTools 2.0.0 * dt and unite module * update Dockerfile * updates news --------- Co-authored-by: Charco Hui <charcohui93@gmail.com> * Update Dockerfile * Add legacy iNZightTS * remove maps module (#377) * correct labels and ensure no spaces in new var names (#375) * Add new Time Series module (+ legacy) * legacy panel name * iNZightTSLegacy::seasonplot * legacy plot working * update dockerfile * ts2 * update dockerfiles * legacy:: * iNZightTS:: * try patched inzightts * update decompose and seasonal TS plot * use pak as pkg manager * copy the file * set-up minimal pkgs * install all deps * fable() only searches global env, so put log_if there * recommit without format changes --------- Co-authored-by: Charco Hui <charcohui93@gmail.com> * Update survey object when data changes * update survery obj in summary * update survey object when global data changes * update plot params * add ct help (#381) * cleanup (#380) * update news, version * update to iNZightPlots v2.14 branch * relative width option (closes #389) * remove old code and fix styling (#390) * remove old code and fix styling * update news Fixes: CI level input width #386 Redirect to visualize tab after example import #384 Auto manes when storing values #385 Remove 'go.to.old' #382 --------- Co-authored-by: Tom Elliott <tomelliottnz@gmail.com> * update news * fixes #392 (#394) * Check count > 0 (fixes #384) * moved logic from modal to primary buttons (#395) --------- Co-authored-by: Charco Hui <charco.hui@auckland.ac.nz> Co-authored-by: Charco Hui <charcohui93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393.