Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/configurable #343

Merged
merged 12 commits into from
Dec 11, 2023
Merged

Feature/configurable #343

merged 12 commits into from
Dec 11, 2023

Conversation

tmelliott
Copy link
Member

No description provided.

tmelliott and others added 5 commits August 18, 2023 18:17
* Create new branch tracking iNZightVIT/Lite2 changes

* fix conflicts

* modes?

* ui fix

* fix import

* fix lite2 env variable

* prevent dataset to show before confirm

* fix url import

* remove comments

* fix rdata data selection bug

* fix(server): LITE_ -> CAS_; bug in decryption code; import wkb, openssl

- Replace LITE_ with CAS_ (for now) given this is still a hard-coded solution
- fix parentheses in the raw2char / aes_cbc_decrypt logic
- remove wkb code and just import the wkb package (minimal overhead)
- remove library calls, use namespacing instead (openssl, wkb)

* wrap LITE2 if

* add function sample_if_lite2

* fix lite2 UI

* fix datetime

---------

Co-authored-by: Charco Hui <phui285@gmail.com>
It seems that row.names() and colnames() are triggering the reload, and by refactoring slightly the loading-loop seems to go away.
Copy link

railway-app bot commented Nov 21, 2023

This PR is being deployed to Railway 🚅

Lite: ◻️ REMOVED

Store config as an unaltered list; display version info on landing page. Minor refactor of some parameter handling.
@tmelliott
Copy link
Member Author

Configuration (at least on Railway) is not user-session specific, and instead affects the entire instance.

Can we try hacking into the session variable, in Shiny?

@tmelliott
Copy link
Member Author

tmelliott commented Dec 9, 2023

Using session seems to work consistently. However, since session$userData$LITE_VERSION is set after observing the URL parameters, the UI is populated regardless of the configuration (e.g., in server.R some tab panels are "conditionally" included, but currently they are always included).

To do:

  • App tabs react to configuration
  • Components that are disabled should also be disabled internally (e.g., within the 'Export dataset' UI, disable the entire UI if LITE_VERSION == 'CAS')

@tmelliott tmelliott merged commit 9506784 into dev Dec 11, 2023
@tmelliott tmelliott deleted the feature/configurable branch December 11, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants