Improve Chat and Stats by retaining position and adding command lines #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLPdev
approved these changes
Feb 25, 2023
iLPdev
approved these changes
Feb 25, 2023
iLPdev
approved these changes
Feb 25, 2023
|
@eterchun it now seems to be loading the map twice when opening the profile. is there a need for this? |
Delaying EMCO creation resulted in two map loads, one visible post-login.
Rather than loading the window when data is available, we change the title after load.
After 100 the percent measurement becomes irrelevant, so we can increase avoid showing the XP bar.
I had checked the wrong variable
Now listening for events to update bars rather than using a timer. Also added left padding to the text.
Fixing issue where defaults were shown in the XP bar until changes to character xp totals.
iLPdev
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enable automatic position loading via the relevant APIs for Chat and Stats and also move window initialization until after GMCP data has been received to 1) eliminate some errors polluting the log at startup from the various bars based on GMCP data, and 2) allow for the Chat title to reflect the player name (I found a way to change the title for Stats but not for Chat). They also add command lines to the various chat boxes allowing responses in those windows (rather than using the normal command line - so, e.g., you can chat by typing your message directly into the Chat command line).