Adds logic for instanced areas #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to deleteArea when switching to a new zone if that zone is "instanced". There may be instances where this is incorrect, but I haven't run into any since adding the logic for ignoring "Battlefield".
This likely would have led to the deletion of the area a user logged into.
|
@eterchun Is the second commit the addendum of which you spoke? This is ready to go? |
|
It is, and it should be. I've been using it in the meantime and it successfully deletes maps when I re-enter dungeons and they are then remapped. I haven't confirmed that the remapped areas have the correct exit linking, but they have all been visually correct. |
iLPdev
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to deleteArea when switching to a new zone if that zone is "instanced". There may be instances where this is incorrect, but I haven't run into any since adding the logic for ignoring "Battlefield".