Line-based triggers for chat capture #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses iLPdev#4 but should be tested because improper line captures can cause Mudlet to crash. Also, I am currently getting a strange echo of chats and events, which seems to be server-related, but I can't be sure.
iLPdev
approved these changes
Feb 17, 2023
|
this has been working perfectly ever since admin modified the GA sequence. let's move it to the main branch and keep an eye on any future changes to GA (given the ongoing newline bug on server side) that might influence this code on our end. closes #4 |
iLPdev
added a commit
that referenced
this pull request
Feb 23, 2023
fix(chat): Chane to Line-based triggers for chat capture (#44) Moving to line-based triggers for chat capture This addresses #4 but should be tested because improper line captures can cause Mudlet to crash. Also, I am currently getting a strange echo of chats and events, which seems to be server-related, but I can't be sure. Authored-by: eterchun <edward.terchunian@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made to solve #4 . This will require changes to the package to remove the current communication triggers and should also be tested because bugs can cause severe errors in Mudlet (e.g., crashes).