GitHub Actions: Enable masking option for ECR Login #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a warning about the 'mask-password' option for the "amazon-ecr-login" action. If ran in debug mode, the password will be outputted. By default this option is not enabled as the expectation is to run the service after the deployment but as a secondary job. As such the password cannot be masked as it is needed to run the service. https://github.com/aws-actions/amazon-ecr-login#run-an-image-as-a-service However, this is not the workflow we have set up, therefore we need to enable the option to mask the password.
djmetzle
approved these changes
Dec 11, 2023
|
ooof looks like there is quite a bit of places https://github.com/search?q=org%3AiFixit%20aws-actions%2Famazon-ecr-login%40v1&type=code |
ardelato
added a commit
to iFixit/react-commerce
that referenced
this pull request
Dec 11, 2023
There is a warning about the 'mask-password' option for the "amazon-ecr-login" action. If ran in debug mode, the password will be outputted. By default this option is not enabled as the expectation is to run the service after the deployment but as a secondary job. As such the password cannot be masked as it is needed to run the service. https://github.com/aws-actions/amazon-ecr-login#run-an-image-as-a-service However, this is not the workflow we have set up, therefore we need to enable the option to mask the password. Reference: iFixit/vigilo#19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a warning about the 'mask-password' option for the "amazon-ecr-login" action. If ran in debug mode, the password will be outputted. By default this option is not enabled as the expectation is to run the service after the deployment but as a secondary job. As such the password cannot be masked as it is needed to run the service.
https://github.com/aws-actions/amazon-ecr-login#run-an-image-as-a-service
However, this is not the workflow we have set up, therefore we need to enable the option to mask the password.
qa_req 0