Gayson 吉训振 #7
Open
Gayson 吉训振 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
版本修订，解决了爆炸bug |
|
删掉了一点无用文件 |
|
可以可以，差点弄错名字了 🥇 |
|
工程索引有问题，没法运行哦~ |
yimingtang
reviewed
Jul 4, 2017
| import UIKit | ||
|
|
||
| class NoteDetailController: UIViewController { | ||
| @IBOutlet weak var context: UITextView! |
|
yimingtang
requested changes
Jul 4, 2017
|
|
||
| protocol NoteDetailDelegate { | ||
| func newNote(content: String) | ||
| func modifyNote(content: String, indexPath: IndexPath) |
There was a problem hiding this comment.
这几个方法里要传 indexPath 不合理。不能假定自己是被列表唤起的吧。
| @IBOutlet weak var delete: UIButton! | ||
|
|
||
| var status: OpenStatus? | ||
| var indexPath: IndexPath? |
There was a problem hiding this comment.
依赖 indexPath 不合理，假定自己的调用者是列表了。直接持有一个 Note 对象得了。
| let cellNib = UINib(nibName: "NoteItem", bundle: nil) | ||
| noteListView.register(cellNib, forCellReuseIdentifier: "noteItem") | ||
|
|
||
| noteListView.delegate = self |
There was a problem hiding this comment.
如果你大量用 Storyboard 为什么不全用 SB 设置？
There was a problem hiding this comment.
对storyboard如何单独设计一个viewcell不太熟悉，所以用了xib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.