高亦乐 #4
Open
高亦乐 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
大概看了一下，基本功能应该有了。考虑到之前没啥 iOS 开发基础，如果独立做到这种程度应该可以了。不过给人感觉是直接照抄了人家的代码。运行时竟然要塞个东西到用户目录下，这等于不可用啊。 几个点忍不住提一下：review 了前面几个文件，你看的这份代码纰漏很多，误人子弟，不要学。 |
yimingtang
requested changes
Jul 4, 2017
| @interface JWDetailViewController : UIViewController | ||
|
|
||
| //文本， 备忘录内容 | ||
| @property (nonatomic, strong) NSString *detail; |
| //文本， 备忘录内容 | ||
| @property (nonatomic, strong) NSString *detail; | ||
| //顶部，创建时间 | ||
| @property (nonatomic, strong) NSString *createTime; |
There was a problem hiding this comment.
命名上，首先 createTime 会让人误认为是时间类型，很显然你这里是字符串类型。其次，词性，created 嘛。
| //顶部，创建时间 | ||
| @property (nonatomic, strong) UILabel *timeLabel; | ||
| //UITextView | ||
| @property (nonatomic, strong) UITextView *textView; |
There was a problem hiding this comment.
view controller 里的 view 以可写属性暴露给外面太危险了。。。
| //UITextView | ||
| @property (nonatomic, strong) UITextView *textView; | ||
| //实现UpdateMemoProtocol协议的代理，上一级的viewController | ||
| @property (nonatomic) id<UpdateMemoProtocol> delegate; |
| // 需要实现UITextViewDelegate和UIAlertViewDelegate协议 | ||
| @interface JWDetailViewController () <UITextViewDelegate,UIAlertViewDelegate> { | ||
|
|
||
| bool textHasChanged;//标记文本是否更改过 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.