Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加 collectionview datasource 的 insert remove #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

monzy613
Copy link
Member

No description provided.

@mention-bot
Copy link

@monzy613, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yimingtang to be a potential reviewer

@codecov-io
Copy link

codecov-io commented Aug 29, 2016

Current coverage is 50.70% (diff: 0.00%)

Merging #1 into master will decrease coverage by 2.41%

@@             master         #1   diff @@
==========================================
  Files            64         64          
  Lines          1700       1781    +81   
  Methods         642        660    +18   
  Messages          0          0          
  Branches        140        151    +11   
==========================================
  Hits            903        903          
- Misses          765        846    +81   
  Partials         32         32          

Powered by Codecov. Last update 9c99cd2...9429f69

@yimingtang
Copy link
Member

yimingtang commented Aug 29, 2016

  1. Project 文件有问题。在 pod install 后,打开工程文件,调出右边的 file inspector,重选一下 Xcode file format。
  2. 命名上做一下调整。
  3. Example 最好把删除功能也加上。
  4. 再有时间的话,把 tests 补上。

@@ -40,4 +40,9 @@
- (__kindof BUKCollectionViewItem *)itemAtIndexPath:(NSIndexPath *)indexPath;
- (void)refresh;

// dynamics
- (void)insertSection:(BUKCollectionViewSection *)section index:(NSInteger)index;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-insertSection:atIndex:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants