Exp date on view recurring contribution series -> 1969-12

[KarinG]

Expiry in this screen was only the card used to initiate the recurring series transaction -> hit View again (at the bottom there) to see the current card on file details.

But 1969-12 is definitively a bug that can be fixed - not at all critical though.

[adixon]

Noted. I'm not at all sure that field should still exist, core does some tracking of expiry dates and that card on file link will pull up the real expiry date.

FWIW - 1969-12 being generated from an empty unix timestamp.

[KarinG]

I know and I agree -> best we don't store that field at all - after a few years it has no added value to know what the expiry date was the day that donor started their recurring contribution series. We can keep it on the list of things to do for a next round of updates.

[adixon]

Fixed with 6aef38a

Fixed by showing N/A if the expiry date string is empty.

In fact, we're not storing it, the civicrm payment token table is, and it does get updated when civicrm is used to update card credentials, so it's not a terrible thing. All I'm doing with this piece of code is exposing that field to the view of the recurring schedule, for credit cards, which at some point might be something core could do.