Merge branch 'readability-nested-side-effect-call' into 'master'

Improve readability by removing a nested call() with side effects See merge request i4/infra/wake-on-lan!2
i4 · Aug 29, 2022 · a1df4c0 · a1df4c0
2 parents 661eebb + 7318fa7
commit a1df4c0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/wol.py b/wol.py
@@ -99,7 +99,8 @@ def handle(self):
 				hostname = self.rfile.readline().strip()
 				if hostname:
 					logging.info('Request WoL at "{}" from {}'.format(hostname, client))
-					self.wfile.write(b"success\n" if wake(hostname) else b"failed\n")
+					success = wake(hostname)
+					self.wfile.write(b"success\n" if success else b"failed\n")
 				else:
 					break
 		except socket.timeout: