Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions on how to build Docker image #1097

Closed
tiagostutz opened this issue Mar 24, 2021 · 2 comments
Closed

Instructions on how to build Docker image #1097

tiagostutz opened this issue Mar 24, 2021 · 2 comments

Comments

@tiagostutz
Copy link

Is your feature request related to a problem? Please describe.

I struggled building a NextJS Docker image because the provided Docker image doesn't have the COPY --from=builder /app/next-i18next.config.js ./ instruction. So I had problems with Initial locale argument was not passed into serverSideTranslations and next-i18next was unable to find a user config

Describe the solution you'd like

There could be in the README instructions a section "Deploying with Docker" that has the instructions on how to put the config file in the build process

Describe alternatives you've considered

This could be:

## Deployment Tips
When building your Docker image following NextJS instructions, please remember to:
- uncomment the line `COPY --from=builder /app/next.config.js ./`
- add the following line right above that: `COPY --from=builder /app/next-i18next.config.js ./`

Additional context

N/A

@tiagostutz tiagostutz changed the title Give instructions on how to build Docker image Instructions on how to build Docker image Mar 24, 2021
@isaachinman
Copy link
Contributor

Of course, when building in Docker, you'll need to copy next-i18next.config.js just like all other source files. If you feel mentioning this is relevant, feel free to open a PR to update the documentation.

fangyibkk added a commit to fangyibkk/next-i18next that referenced this issue Apr 12, 2021
Update some note according to this [issue](i18next#1097)
@fangyibkk
Copy link
Contributor

Encounter the same problem and found this really help. Thanks a lot, I will create the PR.

isaachinman pushed a commit that referenced this issue Apr 13, 2021
* docs: Update README Dockerfile

Update some note according to this [issue](#1097)

* Add another section called Notes

Move the Docker deployment note to such section
DanPurdy pushed a commit to DanPurdy/next-i18next that referenced this issue Apr 30, 2021
* docs: Update README Dockerfile

Update some note according to this [issue](i18next#1097)

* Add another section called Notes

Move the Docker deployment note to such section
web-developer77 added a commit to web-developer77/next-i18next that referenced this issue Aug 2, 2021
* docs: Update README Dockerfile

Update some note according to this [issue](i18next/next-i18next#1097)

* Add another section called Notes

Move the Docker deployment note to such section
Creative0624 added a commit to Creative0624/I8LNEXT that referenced this issue Sep 23, 2024
* docs: Update README Dockerfile

Update some note according to this [issue](i18next/next-i18next#1097)

* Add another section called Notes

Move the Docker deployment note to such section
crypto523 pushed a commit to crypto523/next-i18 that referenced this issue Oct 4, 2024
* docs: Update README Dockerfile

Update some note according to this [issue](i18next/next-i18next#1097)

* Add another section called Notes

Move the Docker deployment note to such section
dev-arrow added a commit to dev-arrow/next-i18next that referenced this issue Nov 25, 2024
* docs: Update README Dockerfile

Update some note according to this [issue](i18next/next-i18next#1097)

* Add another section called Notes

Move the Docker deployment note to such section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants