chore(size-limit): check also for next-app dist folder (#1972)

* chore(size-limit): check also for next-app dist folder * ci: build examples before running check size * ci: check-size just after builds
i18next · Oct 20, 2022 · 55a285b · 55a285b
1 parent 47a0295
commit 55a285b
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,12 +28,15 @@ jobs:
       - name: Build next-i18next
         run: npm run build
 
-      - name: Check dist for ecmascript compliance
-        run: npm run check-dist
+      - name: Build examples
+        run: npm run build:examples
 
       - name: Check size limits
         run: npm run check-size
 
+      - name: Check dist for ecmascript compliance
+        run: npm run check-dist
+
       - name: Unit tests
         run: npm test
 

diff --git a/.size-limit.cjs b/.size-limit.cjs
@@ -3,6 +3,38 @@
 const fullEsmMaxSize = "23KB";
 const fullCjsMaxSize = "46KB";
 
+const getSimpleExamplePageLimits = () => {
+  const dir = './examples/simple/.next'
+  let manifest;
+  try {
+    manifest = require(`${dir}/build-manifest.json`);
+  } catch (e) {
+    throw new Error(
+        'Cannot find a NextJs build folder, did you forget to run build:examples ?'
+    );
+  }
+  const limitCfg = {
+    defaultSize: '90kb',
+    pages: {
+      '/': '85kb',
+      '/404': '90kb',
+      '/_app': '100kb',
+      '/_error': '80Kb',
+      '/second-page': '85Kb'
+    },
+  };
+  let pageLimits = [];
+  for (const [uri, paths] of Object.entries(manifest.pages)) {
+    pageLimits.push({
+      name: `Example app: page '${uri}'`,
+      limit: limitCfg.pages?.[uri] ?? limitCfg.defaultSize,
+      webpack: false,
+      path: paths.map(p => `${dir}/${p}`)
+    });
+  }
+  return pageLimits;
+}
+
 const modifyWebpackConfig = config => {
   config.resolve = {};
   config.resolve.fallback = { "path": false, "fs": false };
@@ -16,7 +48,7 @@ const modifyWebpackConfig = config => {
  */
 module.exports = [
   // ###################################################
-  // ESM full bundle
+  // Dist ESM full bundle
   // ###################################################
   {
     name: "ESM (import everything *)",
@@ -26,7 +58,7 @@ module.exports = [
     modifyWebpackConfig,
   },
   // ###################################################
-  // Commonjs full bundle
+  // Fist commonjs full bundle
   // ###################################################
   {
     name: "CJS (require everything *)",
@@ -35,5 +67,9 @@ module.exports = [
     webpack: true,
     limit: fullCjsMaxSize,
     modifyWebpackConfig,
-  }
+  },
+  // ###################################################
+  // Example apps
+  // ###################################################
+  ...getSimpleExamplePageLimits(),
 ];
diff --git a/package.json b/package.json
@@ -44,6 +44,7 @@
     "build:esm": "BABEL_ENV=esm babel src --extensions '.ts,.tsx' --out-dir dist/esm --copy-files",
     "build:types": "tsc --noEmit false --declaration --emitDeclarationOnly --outDir dist/types",
     "build": "npm run clean && npm run build:cjs && npm run build:es && npm run build:esm && npm run build:types",
+    "build:examples": "run-s build:example:*",
     "build:example:simple": "cd examples/simple && npm run build",
     "build:example:ssg": "cd examples/ssg && npm run build",
     "install:example:simple": "cd examples/simple && npm install",
@@ -131,9 +132,9 @@
     "npm-run-all": "^4.1.5",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
+    "size-limit": "8.1.0",
     "start-server-and-test": "^1.14.0",
     "typescript": "^4.7.4",
-    "size-limit": "8.1.0",
     "webpack": "5.74.0"
   },
   "dependencies": {