fix: resolve memory leak, by cloning always from the main instance (#…

…1110) * fix: resolve memory leak, by cloneing always from the main instance * Update src/createClient/node.ts * Update src/createClient/node.ts Co-authored-by: Isaac Hinman <isaac@isaachinman.com>
i18next · Mar 30, 2021 · 2911d35 · 2911d35 · vercel · Mar 30, 2021
1 parent 5d9cf10
commit 2911d35
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/createClient/node.ts b/src/createClient/node.ts
@@ -3,13 +3,15 @@ import i18nextFSBackend from 'i18next-fs-backend'
 
 import { InternalConfig, CreateClientReturn, InitPromise, I18n } from '../types'
 
-let instance: I18n
+let globalInstance: I18n
 
 export default (config: InternalConfig): CreateClientReturn => {
-  if (!instance) {
-    instance = i18n.createInstance(config)
+  let instance: I18n
+  if (!globalInstance) {
+    globalInstance = i18n.createInstance(config)
+    instance = globalInstance
   } else {
-    instance = instance.cloneInstance({
+    instance = globalInstance.cloneInstance({
       ...config,
       initImmediate: false,
     })