fix for when passed services are null, should address #296

i18next · Dec 9, 2024 · 0cd29a8 · 0cd29a8
1 parent be02df9
commit 0cd29a8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### 8.0.2
+
+- fix for when passed services are null, should address [296](https://github.com/i18next/i18next-browser-languageDetector/issues/296)
+
 ### 8.0.1
 
 - some environments, throws when accessing document.cookie

diff --git a/i18nextBrowserLanguageDetector.js b/i18nextBrowserLanguageDetector.js
@@ -306,6 +306,7 @@
     }
   };
 
+  // some environments, throws when accessing document.cookie
   let canCookies = false;
   try {
     // eslint-disable-next-line no-unused-expressions
@@ -375,7 +376,7 @@
         }
       });
       detected = detected.map(d => this.options.convertDetectedLanguage(d));
-      if (this.services.languageUtils.getBestMatchFromCodes) return detected; // new i18next v19.5.0
+      if (this.services && this.services.languageUtils && this.services.languageUtils.getBestMatchFromCodes) return detected; // new i18next v19.5.0
       return detected.length > 0 ? detected[0] : null; // a little backward compatibility
     }
     cacheUserLanguage(lng) {

diff --git a/i18nextBrowserLanguageDetector.min.js b/i18nextBrowserLanguageDetector.min.js
diff --git a/src/index.js b/src/index.js
@@ -81,7 +81,7 @@ class Browser {
 
     detected = detected.map((d) => this.options.convertDetectedLanguage(d));
 
-    if (this.services.languageUtils.getBestMatchFromCodes) return detected; // new i18next v19.5.0
+    if (this.services && this.services.languageUtils && this.services.languageUtils.getBestMatchFromCodes) return detected; // new i18next v19.5.0
     return detected.length > 0 ? detected[0] : null; // a little backward compatibility
   }