Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fix generateConfig loop #8164

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

PaideiaDilemma
Copy link
Contributor

Describe your PR, what does it fix/add?

Two of my friends tried out hyprland recently and got into a infinite loop, where it would write the autogenerated config, trigger the hot reload and write the autogenerated config again.

I struggled quite a bit to find out why that happens, but it turns out that it is because this paths var was declared static. So there weren't any subsequent calls to findConfig at all.

I did search for issues but did not find one, although i vaguely remember that someone described this problem somewhere.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

No

Is it ready for merging, or does it need work?

Yes

@PaideiaDilemma
Copy link
Contributor Author

evidence (sorry bad recording):

untitled.mp4

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit e5d3a71 into hyprwm:main Oct 19, 2024
12 checks passed
@PaideiaDilemma PaideiaDilemma deleted the fix-generateConfig branch October 19, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants