Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layouts: Nuke no_gaps_when_only #8072

Merged
merged 1 commit into from
Oct 11, 2024
Merged

layouts: Nuke no_gaps_when_only #8072

merged 1 commit into from
Oct 11, 2024

Conversation

vaxerski
Copy link
Member

NGWO has been deprecated for a while in favor of workspace / window rules that achieve the same thing with less bugs.

Can we finally just nuke it as people keep using it?

@gksudolol
Copy link

Rip it out completely. The same functionality can be replicated with:

workspace = w[t1], gapsin:0, gapsout:0, border:0

@Eclextic
Copy link

Rip it out completely. The same functionality can be replicated with:

workspace = w[t1], gapsin:0, gapsout:0, border:0

Isn't that specifically only for the first workspace then?
So that means if you do the same on the second workspace or a named workspace it won't work?

I really don't care about this feature anyways so... :3

@leiserfg
Copy link
Contributor

leiserfg commented Oct 11, 2024

I use this feature, and it's not buggy for me, is there a replacement that does not imply having to set a rule per workspace?

Edit: t1 refers to the amount of tiled windows, not the workspace number, so you can burn it with fire. But please keep a comment somewhere about how to achieve this.

@gksudolol
Copy link

Isn't that specifically only for the first workspace then?

t Is for tiled-only clients i.e non-floating/fullscreen. Setting it to 1 because we don't want it to apply if there's more than 1 window in the workspace

So that means if you do the same on the second workspace or a named workspace it won't work?

By default, that snippet will be all workspaces. But you can set a number, range or named:

# Only workspace 1
workspace = 1, w[t1], gapsin:0, gapsout:0, border:0

# Only workspaces from 1 to 3
workspace = r[1-3], w[t1], gapsin:0, gapsout:0, border:0

# Only a specific named workspace
workspace = name:myworkspace, w[t1], gapsin:0, gapsout:0, border:0

@Honkazel
Copy link
Contributor

Rip it out completely. The same functionality can be replicated with:

workspace = w[t1], gapsin:0, gapsout:0, border:0

rounding=0?

@vaxerski
Copy link
Member Author

But please keep a comment somewhere about how to achieve this.

https://wiki.hyprland.org/Configuring/Workspace-Rules/#smart-gaps

@vaxerski
Copy link
Member Author

thanks for the input

@vaxerski vaxerski merged commit d655a10 into main Oct 11, 2024
20 checks passed
@nktnet1
Copy link
Contributor

nktnet1 commented Oct 13, 2024

To fully replicate no_gaps_when_only: true, in addition to

workspace = w[t1], gapsin:0, gapsout:0, border:0

I also had to add

windowrulev2 = noborder, fullscreen:1

for maximised windows when there is more than one in a workspace.

@vaxerski
Copy link
Member Author

workspace = w[t1], gapsin:0, gapsout:0, border:0
workspace = w[tg1], gapsin:0, gapsout:0, border:0
workspace = f[1], gapsin:0, gapsout:0, border:0

As listed on the wiki, enjoy

sudoAlphaX added a commit to sudoAlphaX/dotfiles that referenced this pull request Oct 14, 2024
@kRHYME7
Copy link

kRHYME7 commented Oct 19, 2024

Hi! How can I possibly have my borders/etc back for floating mode. (Looks weird when BG are the same)

image

Scenario:

  • 1 tiled window
  • N floating window/s (pop ups and other stuff)

@vaxerski
Copy link
Member Author

workspace = w[t1], gapsout:0, gapsin:0
workspace = w[tg1], gapsout:0, gapsin:0
workspace = f[1], gapsout:0, gapsin:0
windowrulev2 = bordersize 0, floating:0, onworkspace:w[t1]
windowrulev2 = rounding 0, floating:0, onworkspace:w[t1]
windowrulev2 = bordersize 0, floating:0, onworkspace:w[tg1]
windowrulev2 = rounding 0, floating:0, onworkspace:w[tg1]
windowrulev2 = bordersize 0, floating:0, onworkspace:f[1]
windowrulev2 = rounding 0, floating:0, onworkspace:f[1]

Kahlenden added a commit to Kahlenden/nixos-dotfiles that referenced this pull request Oct 25, 2024
Kahlenden added a commit to Kahlenden/nixos-dotfiles that referenced this pull request Oct 25, 2024
Kahlenden added a commit to Kahlenden/nixos-dotfiles that referenced this pull request Oct 25, 2024
@JohnMH
Copy link
Contributor

JohnMH commented Oct 26, 2024

It would generally be a good idea to have a deprecation warning before a setting/feature is removed so end users are aware.

@vaxerski
Copy link
Member Author

as discussed in another issue (I forgot the #) I put those in the release notes.

@vaxerski vaxerski deleted the nuke-ngwo branch November 18, 2024 14:51
@11xx 11xx mentioned this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants