Create notification table #9360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eecde66 to
855bac0
Compare
mtomilov
commented
Feb 18, 2025
h/models/notification.py
Outdated
| REPLY = "reply" | ||
|
|
||
|
|
||
| class Notification(Base, Timestamps): |
There was a problem hiding this comment.
In theory we could add send column on top of what we get from Timestamp but it's probably okay.
mtomilov
commented
Feb 18, 2025
h/models/notification.py
Outdated
| """FK to user.id""" | ||
| user: Mapped[User] = relationship(back_populates="notifications", uselist=False) | ||
|
|
||
| type: Mapped[NotificationType] |
There was a problem hiding this comment.
Bare bones version for now to support mention edits.
We will probably add status and actor_id (triggered by) in later phases.
33041c1 to
a5764a4
Compare
a5764a4 to
ebfc2fe
Compare
mtomilov
commented
Feb 19, 2025
| index=True, | ||
| ) | ||
| """FK to annotation.id - the annotation that triggered this notification""" | ||
| source_annotation = relationship( |
There was a problem hiding this comment.
Renamed this after discussion in slack
mtomilov
commented
Feb 19, 2025
| index=True, | ||
| ) | ||
| """FK to user.id - the user receiving the notification""" | ||
| recipient = relationship("User", uselist=False) |
marcospri
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9359
This adds notification table to the app models together with its sql migration
Testing
admin@example.com/maildirectory for incoming emails