Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mention user link #9346

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix mention user link #9346

merged 1 commit into from
Feb 12, 2025

Conversation

mtomilov
Copy link
Contributor

@mtomilov mtomilov commented Feb 12, 2025 •
edited
Loading

Refs #9304

Actually we want provide a link to user profile in authority not user provided url.
See details in this thread

Testing instructions in the PoC #9279

@mtomilov mtomilov force-pushed the fix-mention-user-url branch from 330a7ff to ab71d50 Compare February 12, 2025 08:52
mtomilov
mtomilov commented Feb 12, 2025
View reviewed changes
@mtomilov mtomilov force-pushed the fix-mention-user-url branch from ab71d50 to f05b8db Compare February 12, 2025 08:54
@mtomilov mtomilov mentioned this pull request Feb 12, 2025
Merged
@mtomilov mtomilov force-pushed the fix-mention-user-url branch from f05b8db to 47b02ad Compare February 12, 2025 09:03
@mtomilov mtomilov changed the title Fix mention user url Fix mention user link Feb 12, 2025
acelaya
acelaya approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just suggested taking the opportunity to build the URL using the user activity route instead of the streamer route.

@mtomilov mtomilov force-pushed the fix-mention-user-url branch 2 times, most recently from 19cf827 to b4ebf33 Compare February 12, 2025 12:01
@mtomilov mtomilov force-pushed the fix-mention-user-url branch 2 times, most recently from 24e76ba to 675ad2b Compare February 12, 2025 14:15
@mtomilov mtomilov force-pushed the fix-mention-user-url branch from b98d467 to fd3f402 Compare February 12, 2025 15:12
@mtomilov mtomilov merged commit 8002f93 into main Feb 12, 2025
11 checks passed
@mtomilov mtomilov deleted the fix-mention-user-url branch February 12, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospri marcospri marcospri approved these changes

@acelaya acelaya acelaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtomilov @marcospri @acelaya