URL changes for reset password, forgot password and register. #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config.add_route('activate', '/activate/{id}/{code}') | ||
| config.add_route('forgot_password', '/forgot_password') | ||
| config.add_route('forgot-password', '/forgot-password') |
There was a problem hiding this comment.
It looks like we tend to use underscores for route names (the first argument).
There was a problem hiding this comment.
The failing tests will also be fixed when you change the route name back to forgot_password.
39bfece to
d0d66b3
Compare
…register. https://trello.com/c/Yiraeqzs/408-logged-out-form-url-changes-and-redirects To test: In /: create new user In acount/settings: changed email changed password In stream: logged out and logged in with new password, forgot password and reset it
d0d66b3 to
b6a2fc5
Compare
|
This is looking great! 👍 |
It was removed in 0f747a0 and is not needed anymore.
|
I'll merge this now. As Nick mentioned on Slack, it would be nice to have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/Yiraeqzs/408-logged-out-form-url-changes-and-redirects
Related to:
hypothesis/client#68
Test scenarios:
changed email
changed password
logged out and logged in with new password,
forgot password and reset it
N.B. We will need to coordinate the deployment of this change carefully, as we may need to update our nginx configuration._