Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show direct links on stream page when available #3550

Closed
wants to merge 3 commits into from

Conversation

finitud
Copy link
Contributor

@finitud finitud commented Jun 27, 2016

Currently the links on the stream page point to the original annotated document. This pull request makes these links to be direct links to the annotation.

https://trello.com/c/iipUgujB/373-direct-link-to-annotation-from-stream-card-document-link

@finitud finitud added the WIP label Jun 27, 2016
@codecov-io
Copy link

codecov-io commented Jun 27, 2016

Current coverage is 72.79%

Merging #3550 into master will not change coverage

@@             master      #3550   diff @@
==========================================
  Files           132        132          
  Lines          4702       4702          
  Methods           0          0          
  Messages          0          0          
  Branches        527        527          
==========================================
  Hits           3423       3423          
+ Misses         1212       1209     -3   
- Partials         67         70     +3   

Sunburst

Powered by Codecov. Last updated by fc69219...04e4735

@nickstenning
Copy link
Contributor

What's the status of this? Is it really WIP?

@finitud
Copy link
Contributor Author

finitud commented Jun 29, 2016

Yes, I'm refactoring some bits of code around this PR on @robertknight suggestion.

@finitud finitud force-pushed the direct-document-link-from-stream branch from 669f23f to 04e4735 Compare June 29, 2016 13:28
@nickstenning
Copy link
Contributor

I'm going to close this PR. Please reopen against hypothesis/client.

There are a couple of ways for you to move the PR. Here's one:

  1. On this branch, run git format-patch master
  2. Clone the new repository: cd .. && git clone git@github.com:hypothesis/client.git.
  3. Copy all the *.patch files into the new repository: cp h/*.patch client
  4. Change directory to the new repository: cd client
  5. Checkout a new branch in the new repository: git checkout -b my-branch-name
  6. Apply the patches to that branch by running git am *.patch

@finitud
Copy link
Contributor Author

finitud commented Jun 29, 2016

The changes are now being tracked at hypothesis/client#1

@nickstenning nickstenning deleted the direct-document-link-from-stream branch July 1, 2016 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants