Expose custom return type for our mount function #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b80800 to
ece454e
Compare
robertknight
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom type definition for the objects returned by our
mount()function.The type is based on the "official" enzyme types from DefinitelyTyped, but ignoring
ShallowWrapperand the methods we don't use fromReactWrapper.I also decided to name the main type
ComponentWrapper, to avoid coupling the name with a specific UI framework, but I don't have a strong opinion about this name.I checked
client,frontend-shared,lms,handviato see what parts of the wrapper object were already in use, and defined them here.I also tested this via yalc in client project, and verified my IDE is now smarter about code autocompletion.