Add prepareContainer option to mount function #59
Conversation
|
Since we have already agreed on this API, I'll just go ahead and merge it. |
|
|
||
| /** | ||
| * When `connected` is true, allows to customize the container to which the | ||
| * wrapper is connected to. |
There was a problem hiding this comment.
I would phrase this as "allows customizing the DOM container in which the component is mounted".
| let wrapper; | ||
| if (connected) { | ||
| const container = document.createElement('div'); | ||
| container.setAttribute('data-enzyme-container', ''); | ||
| containers.push(container); | ||
|
|
||
| prepareContainer?.(container); |
There was a problem hiding this comment.
It is possible we might encounter use cases in future where the callback needs the container to be connected (ie. in the body) when called. This would be necessary to resolved computed styles for example. I haven't seen any existing use cases where this is necessary.
There was a problem hiding this comment.
For now I added the call before appending the container to the body, because that was the approach in all places where we were setting styles.
But yeah, it's possible we need to do it the other way around in the future.
As discussed in slack, this PR adds a
prepareContainer?: (container: HTMLElement) => voidoption to themountfunction, which allows to customize the container whenconnectistrue.