Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package to v3.1.1 #96

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Package to v3.1.1 #96

merged 1 commit into from
Jun 14, 2021

Conversation

lyzadanger
Copy link
Contributor

@lyzadanger lyzadanger commented Jun 11, 2021

Version the package.

This started as a version-bump to 3.1.0, but a typo in the CHANGELOG led to 3.1.1 because the 3.0.0 tag had already been pushed.

@lyzadanger lyzadanger requested a review from robertknight June 11, 2021 14:10
Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In general I feel that straightforward package updates like this (ie. version bump + CHANGELOG update) do not require review, although feel free to request one if you want input on something specific.

@lyzadanger
Copy link
Contributor Author

In general I feel that straightforward package updates like this (ie. version bump + CHANGELOG update) do not require review

I tend to agree, especially from a PITA perspective: any requested changes here would end up with a new commit hash, which would in turn muck up the tag that has already been pushed at this point. Let's discuss in our next team chat.

@lyzadanger lyzadanger merged commit 24cad39 into main Jun 14, 2021
@lyzadanger lyzadanger deleted the version-3.1.1 branch June 14, 2021 14:51
@lyzadanger lyzadanger mentioned this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants