Add support for other "text-like" input types to TextInput #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esanzgar
approved these changes
Sep 9, 2021
| @@ -9,13 +9,12 @@ import classnames from 'classnames'; | |||
| * the rendered `input` element. | |||
| * @prop {boolean} [hasError] - There is an error associated with this input. Will | |||
| * set some error styling. | |||
| * @prop {'email'|'search'|'text'|'url'} [type="text"] - Set the <input> type: | |||
There was a problem hiding this comment.
We could add 'password' too (while not having a specific component for that).
Something to notice about the 'search' is that in Chrome it adds a 'X' cancel symbol. I am not sure if we mind that:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search#differences_between_search_and_text_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on converting LMS'
URLPickerover to use the sharedModal, I was also wanting to convert it to useTextInputfor its URL-input field. However,URLPickerrelies on browser validation oninput type="url", andTextInputwasn't allowing anytypeexcept text.This PR adds support for the most "text-like" input
types, per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input — we could open this up to more in the future if we wanted.