Do not allow text to be selected in Select options #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1657 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 61 61
Lines 1040 1040
Branches 402 402
=========================================
Hits 1040 1040 ☔ View full report in Codecov by Sentry. |
Closed
1 task
robertknight
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid text to be selectable in
Select.Optioncomponents.This is specially important as we plan to support selecting multiple options via Shift + click, which selects all text in between by default.
Before:
Grabacion.de.pantalla.desde.2024-08-14.10-17-41.webm
After:
Grabacion.de.pantalla.desde.2024-08-14.10-18-09.webm