Add sortable indicator icon to DataTable sortable columns
#1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8daddbf to
2489461
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 61 61
Lines 1036 1040 +4
Branches 398 402 +4
=========================================
+ Hits 1036 1040 +4 ☔ View full report in Codecov by Sentry. |
2489461 to
3d784c2
Compare
DataTable sortable columns
acelaya
commented
Aug 8, 2024
There was a problem hiding this comment.
I took this icon from Figma
robertknight
reviewed
Aug 8, 2024
Good catch |
e2d95a4 to
676ff61
Compare
676ff61 to
22f05af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve a bit discoverability of orderable
DataTablecolumns by adding an icon indicating it.Up until now, only the actively ordered column had an icon, making it impossible to tell which other columns could be used for ordering.
This is a need that was initially requested in https://hypothes-is.slack.com/archives/C07NXBDNW/p1722017120383689?thread_ts=1722016950.558659&cid=C07NXBDNW, and the design was provided here https://www.figma.com/design/rugQ2tONStRF3RL9UXZaGW/Search-Explorations?node-id=1291-1432.
Before:
Grabacion.de.pantalla.desde.2024-08-08.09-30-36.webm
After:
Grabacion.de.pantalla.desde.2024-08-08.09-29-16.webm